You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/03/13 02:08:39 UTC

Review Request 19166: Added structs for Slaves and Frameworks in the Master.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19166/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Bugs: MESOS-764
    https://issues.apache.org/jira/browse/MESOS-764


Repository: mesos-git


Description
-------

This is anticipation of upcoming Registrar integration changes, in which I will be adding other "slaves" related information.

The other biggest win from a similar change would be the Slave::Executor tasks, where we track 'queuedTasks', 'launchedTasks', 'terminatedTasks', 'completedTasks'.


Diffs
-----

  src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8 
  src/master/master.hpp 49a3e151d53b786027184c14b96371016a926497 
  src/master/master.cpp 2a403336791737d874c26928c9fffea08ac246d8 

Diff: https://reviews.apache.org/r/19166/diff/


Testing
-------

make check

The bot will fail because of my issue in r/19135 ;)


Thanks,

Ben Mahler

Re: Review Request 19166: Added structs for Slaves and Frameworks in the Master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19166/
-----------------------------------------------------------

(Updated March 14, 2014, 6:02 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Minor style change from benh review.


Bugs: MESOS-764
    https://issues.apache.org/jira/browse/MESOS-764


Repository: mesos-git


Description
-------

This is anticipation of upcoming Registrar integration changes, in which I will be adding other "slaves" related information.

The other biggest win from a similar change would be the Slave::Executor tasks, where we track 'queuedTasks', 'launchedTasks', 'terminatedTasks', 'completedTasks'.


Diffs (updated)
-----

  src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8 
  src/master/master.hpp 49a3e151d53b786027184c14b96371016a926497 
  src/master/master.cpp 2a403336791737d874c26928c9fffea08ac246d8 

Diff: https://reviews.apache.org/r/19166/diff/


Testing
-------

make check

The bot will fail because of my issue in r/19135 ;)


Thanks,

Ben Mahler

Re: Review Request 19166: Added structs for Slaves and Frameworks in the Master.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19166/#review37131
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/19166/#comment68479>

    Let's use this style since it's really easy to see the true and false case:
    
    return frameworks.activated.contains(frameworkId)
      ? frameworks.activated[frameworkId]
      : NULL;



src/master/master.cpp
<https://reviews.apache.org/r/19166/#comment68480>

    See style comment above.


- Benjamin Hindman


On March 13, 2014, 1:08 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19166/
> -----------------------------------------------------------
> 
> (Updated March 13, 2014, 1:08 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-764
>     https://issues.apache.org/jira/browse/MESOS-764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is anticipation of upcoming Registrar integration changes, in which I will be adding other "slaves" related information.
> 
> The other biggest win from a similar change would be the Slave::Executor tasks, where we track 'queuedTasks', 'launchedTasks', 'terminatedTasks', 'completedTasks'.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a019f15615d028f3d3628b2611709fc8a3a81bf8 
>   src/master/master.hpp 49a3e151d53b786027184c14b96371016a926497 
>   src/master/master.cpp 2a403336791737d874c26928c9fffea08ac246d8 
> 
> Diff: https://reviews.apache.org/r/19166/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> The bot will fail because of my issue in r/19135 ;)
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>