You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "rthomas320 (via GitHub)" <gi...@apache.org> on 2023/04/05 14:48:43 UTC
[GitHub] [daffodil-vscode] rthomas320 opened a new pull request, #571: - fix problems with tags with multi-line attributes
rthomas320 opened a new pull request, #571:
URL: https://github.com/apache/daffodil-vscode/pull/571
- remove an incorrect newline in the hiddenGroupRef snippet
Closes #562
Closes #563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] rthomas320 commented on a diff in pull request #571: - fix problems with tags with multi-line attributes
Posted by "rthomas320 (via GitHub)" <gi...@apache.org>.
rthomas320 commented on code in PR #571:
URL: https://github.com/apache/daffodil-vscode/pull/571#discussion_r1160011010
##########
src/language/providers/utils.ts:
##########
@@ -276,14 +276,15 @@ export function checkMultiLineTag(
while (currentText.trim() === '' || !currentText.includes('<')) {
--currentLine
currentText = document.lineAt(currentLine).text
- if (!currentText.endsWith('/>')) {
- break
- }
+ // if (!currentText.endsWith('/>')) {
+ // break
+ // }
Review Comment:
I wasn't sure if I needed, I was going to remove after testing, but forgot. It's removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #571: - fix problems with tags with multi-line attributes
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #571:
URL: https://github.com/apache/daffodil-vscode/pull/571#issuecomment-1499195530
@rt320 I will approve one the commented out code @scholarsmate pointed out is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #571: - fix problems with tags with multi-line attributes
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #571:
URL: https://github.com/apache/daffodil-vscode/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #571: - fix problems with tags with multi-line attributes
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #571:
URL: https://github.com/apache/daffodil-vscode/pull/571#discussion_r1159797573
##########
src/language/providers/utils.ts:
##########
@@ -276,14 +276,15 @@ export function checkMultiLineTag(
while (currentText.trim() === '' || !currentText.includes('<')) {
--currentLine
currentText = document.lineAt(currentLine).text
- if (!currentText.endsWith('/>')) {
- break
- }
+ // if (!currentText.endsWith('/>')) {
+ // break
+ // }
Review Comment:
Remove commented code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org