You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/11/08 17:38:12 UTC

[GitHub] leventov commented on a change in pull request #6558: Find duplicate lines with checkstyle; enable some duplicate inspections in IntelliJ

leventov commented on a change in pull request #6558: Find duplicate lines with checkstyle; enable some duplicate inspections in IntelliJ
URL: https://github.com/apache/incubator-druid/pull/6558#discussion_r231993801
 
 

 ##########
 File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/SearchBenchmark.java
 ##########
 @@ -298,11 +298,6 @@ private static SearchQueryBuilder basicD(final BenchmarkSchemaInfo basicSchema)
     dimFilters.add(new InDimFilter(dimName, dimUniformFilterVals, null));
     dimFilters.add(new SelectorDimFilter(dimName, "3", null));
     dimFilters.add(new BoundDimFilter(dimName, "100", "10000", true, true, true, null, null));
-    //CHECKSTYLE.OFF: Regexp - TODO intentional duplicates?
 
 Review comment:
   As per https://github.com/apache/incubator-druid/pull/3848#discussion_r229805136

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org