You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "risdenk (via GitHub)" <gi...@apache.org> on 2023/03/28 17:58:25 UTC
[GitHub] [solr] risdenk opened a new pull request, #1500: remove-collections4
risdenk opened a new pull request, #1500:
URL: https://github.com/apache/solr/pull/1500
https://issues.apache.org/jira/browse/SOLR-XXXXX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1500: remove-collections4
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r1152018700
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -307,15 +303,14 @@ public Map<String, SolrPackageInstance> getPackagesDeployedAsClusterLevelPlugins
if (pluginMeta.klass.contains(":")) {
String packageName = pluginMeta.klass.substring(0, pluginMeta.klass.indexOf(':'));
packageVersions.put(packageName, pluginMeta.version);
- packagePlugins.put(packageName, pluginMeta);
+ packagePlugins.computeIfAbsent(packageName, k -> new HashSet<>()).add(pluginMeta);
}
}
Map<String, SolrPackageInstance> ret = new HashMap<>();
for (String packageName : packageVersions.keySet()) {
- if (StrUtils.isNullOrEmpty(packageName) == false
- && // There can be an empty key, storing the version here
- packageVersions.get(packageName)
- != null) { // null means the package was undeployed from this package before
+ // There can be an empty key, storing the version here
+ // null means the package was undeployed from this package before
+ if (!StrUtils.isNullOrEmpty(packageName) && packageVersions.get(packageName) != null) {
Review Comment:
Fixed in bf5a0744091e87c548bebb067ed5a4506662716e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1500: remove-collections4
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r1150999911
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -762,7 +761,7 @@ private boolean returnStoredFields() {
}
private boolean returnDVFields() {
- return CollectionUtils.isNotEmpty(dvFields);
+ return !(dvFields != null && dvFields.isEmpty());
Review Comment:
A comment in line 738 says `dvFields` is always not null, not can simplify
```suggestion
return !dvFields.isEmpty();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1500: remove-collections4
Posted by "sonatype-lift[bot] (via GitHub)" <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1500:
URL: https://github.com/apache/solr/pull/1500#discussion_r1151031492
##########
solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java:
##########
@@ -307,15 +303,14 @@ public Map<String, SolrPackageInstance> getPackagesDeployedAsClusterLevelPlugins
if (pluginMeta.klass.contains(":")) {
String packageName = pluginMeta.klass.substring(0, pluginMeta.klass.indexOf(':'));
packageVersions.put(packageName, pluginMeta.version);
- packagePlugins.put(packageName, pluginMeta);
+ packagePlugins.computeIfAbsent(packageName, k -> new HashSet<>()).add(pluginMeta);
}
}
Map<String, SolrPackageInstance> ret = new HashMap<>();
for (String packageName : packageVersions.keySet()) {
- if (StrUtils.isNullOrEmpty(packageName) == false
- && // There can be an empty key, storing the version here
- packageVersions.get(packageName)
- != null) { // null means the package was undeployed from this package before
+ // There can be an empty key, storing the version here
+ // null means the package was undeployed from this package before
+ if (!StrUtils.isNullOrEmpty(packageName) && packageVersions.get(packageName) != null) {
Review Comment:
<picture><img alt="10% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/10/display.svg"></picture>
<b>*INEFFICIENT_KEYSET_ITERATOR:</b>* Accessing a value using a key that was retrieved from a `keySet` iterator. It is more efficient to use an iterator on the `entrySet` of the map, avoiding the extra `HashMap.get(key)` lookup.
---
<details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
<b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub>
[â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=462748469&lift_comment_rating=1)â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=462748469&lift_comment_rating=2)â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=462748469&lift_comment_rating=3)â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=462748469&lift_comment_rating=4)â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=462748469&lift_comment_rating=5)â]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1500: SOLR-16724: Remove unneeded commons-collections4 dependency
Posted by "risdenk (via GitHub)" <gi...@apache.org>.
risdenk merged PR #1500:
URL: https://github.com/apache/solr/pull/1500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org