You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/08 10:22:06 UTC
[GitHub] [spark] yaooqinn opened a new pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
yaooqinn opened a new pull request #32819:
URL: https://github.com/apache/spark/pull/32819
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
Currently, Spark allows users to set scalability within a Spark application using dynamic allocation. `spark.dynamicAllocation.minExecutors` & `spark.dynamicAllocation.maxExecutors` are used for scaling up and down. Within an application，Spark tactfully use them to request executors from cluster manager according to the real-time workload. Once set, the range is fixed through the whole application lifecycle. This is not very convenient for long-running application when the range should be changeable for some cases, such as:
1. the cluster manager itself or the queue will scale up and down, which looks very likely to happen in modern cloud platforms
2. the application is long-running, but the timeliness, priority, e.t.c are not only determined by the workload with the application, but also by the traffic across the cluster manager or just different moments
3. e.t.c.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
make the dynamic allocation for long term Spark applications
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Configs below are changeable:
spark.dynamicAllocation.maxExecutors
spark.dynamicAllocation.minExecutors
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856648149
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139470/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856764864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139474/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856763418
**[Test build #139474 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139474/testReport)** for PR 32819 at commit [`0f94be6`](https://github.com/apache/spark/commit/0f94be6cee0ce506070f6297bc7356af8031b3a1).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856764864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139474/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857385135
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44044/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857317811
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856648134
**[Test build #139470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139470/testReport)** for PR 32819 at commit [`2975fb6`](https://github.com/apache/spark/commit/2975fb634ab152178a00982e0dfcede7a5a98358).
* This patch **fails RAT tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class SparkListenerExecutorAllocatorRangeUpdate(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856999162
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139496/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856680681
**[Test build #139474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139474/testReport)** for PR 32819 at commit [`0f94be6`](https://github.com/apache/spark/commit/0f94be6cee0ce506070f6297bc7356af8031b3a1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856717752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857322091
**[Test build #139519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139519/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857385135
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44044/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856952525
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857346429
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44044/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856708153
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43997/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857324708
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139519/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856647876
**[Test build #139470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139470/testReport)** for PR 32819 at commit [`2975fb6`](https://github.com/apache/spark/commit/2975fb634ab152178a00982e0dfcede7a5a98358).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857322091
**[Test build #139519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139519/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856946649
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856997957
**[Test build #139496 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139496/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857379361
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44044/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856648149
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139470/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856999162
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139496/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856952525
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44020/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856914280
**[Test build #139496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139496/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-997101966
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #32819:
URL: https://github.com/apache/spark/pull/32819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] advancedxy commented on a change in pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
advancedxy commented on a change in pull request #32819:
URL: https://github.com/apache/spark/pull/32819#discussion_r704346156
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -862,6 +854,15 @@ private[spark] class ExecutorAllocationManager(
}
}
+ override def onExecutorAllocatorRangeUpdate(
+ event: SparkListenerExecutorAllocatorRangeUpdate): Unit = {
+ val newLower = event.lower.getOrElse(_minNumExecutors)
+ val newUpper = event.upper.getOrElse(_maxNumExecutors)
+ validateSettings(newLower, newUpper)
Review comment:
I believe this should be like
```
try {
validateSettings(newLower, newUpper)
_minNumExecutors = newLower
_maxNumExecutors = newUpper
} catch {
....
}
```
Otherwise exception is thrown in this listener.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
##########
@@ -80,6 +82,22 @@ case class SetCommand(kv: Option[(String, Option[String])])
}
(keyValueOutput, runFunc)
+ case Some((DYN_ALLOCATION_MIN_EXECUTORS.key, Some(value))) =>
Review comment:
This is an administration operation. I am not sure it's a good idea to control this by just run set command for long running service such as thrift server as users can easily run this command, and misuse this feature.
How about expose this via the Rest API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857324680
**[Test build #139519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139519/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857324708
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139519/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856717752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856647876
**[Test build #139470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139470/testReport)** for PR 32819 at commit [`2975fb6`](https://github.com/apache/spark/commit/2975fb634ab152178a00982e0dfcede7a5a98358).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856914280
**[Test build #139496 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139496/testReport)** for PR 32819 at commit [`4078349`](https://github.com/apache/spark/commit/4078349ac282f44673918d2c2a40e2a8799ce07a).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856691280
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856680681
**[Test build #139474 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139474/testReport)** for PR 32819 at commit [`0f94be6`](https://github.com/apache/spark/commit/0f94be6cee0ce506070f6297bc7356af8031b3a1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic executor range for dynamic allocation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-856670371
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43993/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #32819: [WIP][SPARK-35677][Core][SQL] Support dynamic range of executor numbers for dynamic allocation
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32819:
URL: https://github.com/apache/spark/pull/32819#issuecomment-857317725
cc @cloud-fan @wangyum thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org