You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "jmsperu (via GitHub)" <gi...@apache.org> on 2026/08/24 13:58:04 UTC
[PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
jmsperu opened a new pull request, #13960:
URL: https://github.com/apache/cloudstack/pull/13960
### Description
`nas.backup.incremental.enabled` is a zone-scoped setting, but `test_backup_recovery_nas.py` read and updated it without a `zoneid`, so a zone override in the test environment would make the suite read the wrong value (and restore the wrong one in `tearDownClass`). This passes `zoneid=cls.zone.id` on the read and on both updates, the same way `test_backup_recovery_veeam.py` handles zone-scoped settings.
Noted by the Copilot review on the 4.22 backport #13877; this is the main-side fix so both branches stay in sync.
### Types of changes
- [x] Test change only (no functional change)
### How Has This Been Tested?
Python syntax check; the change is limited to three Marvin calls in `setUpClass`/`tearDownClass`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5580424562
> do you approve @abh1sar ?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5512178232
do you approve @abh1sar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5439961065
@jmsperu
This is not an issue worth fixing.
The config is zone scoped, but it can be set at the global level as well.
If the zone scoped value is set then that will take precedence over the global value.
This is same with all config. I don't think this requires fixing. The test works with global scope value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5493173496
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5396391377
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13960?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.41%. Comparing base ([`4e4a26b`](https://app.codecov.io/gh/apache/cloudstack/commit/4e4a26b49ef19e892a4b695b6291b21f2117c70b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b442b73`](https://app.codecov.io/gh/apache/cloudstack/commit/b442b738b93e106787c87e5ebd841680548f75a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #13960 +/- ##
======================================
Coverage 3.41% 3.41%
======================================
Files 487 487
Lines 41863 41863
Branches 7912 7912
======================================
Hits 1429 1429
Misses 40234 40234
Partials 200 200
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13960/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13960/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13960?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5493199154
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5440415774
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5493218581
> @jmsperu This is not an issue worth fixing. The config is zone scoped, but it can be set at the global level as well. If the zone scoped value is set then that will take precedence over the global value. This is same with all config. I don't think this requires fixing. The test works with global scope value.
@abh1sar I think it is worth to make the test more robust, this way an operator can decide to run it standalon in a zone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5439780880
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5504213289
<b>[SF] Trillian test result (tid-16862)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56112 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13960-t16862-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: read and set nas.backup.incremental.enabled for the test zone [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13960:
URL: https://github.com/apache/cloudstack/pull/13960#issuecomment-5439800889
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org