You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/07 17:04:00 UTC
[jira] [Commented] (MSKINS-226) Add custom option to explicitly enable AnchorJS along with options
[ https://issues.apache.org/jira/browse/MSKINS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730207#comment-17730207 ]
ASF GitHub Bot commented on MSKINS-226:
---------------------------------------
hboutemy commented on PR #51:
URL: https://github.com/apache/maven-fluido-skin/pull/51#issuecomment-1581209403
I don't understand the whole discussion about generated ids: do we care about it?
the objective is the deep anchors = the "Basic Link" in https://www.bryanbraun.com/anchorjs/
which makes sharing pointers to precise points in documentation easier
this PR makes whole things more complex: do you have any concrete issue with the current links we have in many Doxia generated sites since a few years that you want to disable it by default?
one solution to enable by default but be able to disable could be:
```
<custom>
<fluidoSkin>
<anchorJs>
<disable>true</disable>
</anchorJs>
</fluidoSkin>
</custom>
```
> Add custom option to explicitly enable AnchorJS along with options
> ------------------------------------------------------------------
>
> Key: MSKINS-226
> URL: https://issues.apache.org/jira/browse/MSKINS-226
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-2.0.0-M5
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
>
> Not every one wants this to be enabled by default. An option should be added and the user needs to explicitly enable this, like with other JS-based options.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)