[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11489: [Improvement-11468] Support re running historical version workflow

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11489:
URL: https://github.com/apache/dolphinscheduler/pull/11489#discussion_r947376895


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -358,6 +358,7 @@ public Map<String, Object> execute(User loginUser, long projectCode, Integer pro
         ProcessDefinition processDefinition =
                 processService.findProcessDefinition(processInstance.getProcessDefinitionCode(),
                         processInstance.getProcessDefinitionVersion());
+        processDefinition.setReleaseState(ReleaseState.ONLINE);

Review Comment:
   It's better remove the release state checking logic since this check is meaningless if `setReleaseState(ReleaseState.ONLINE)` are added.
   https://github.com/apache/dolphinscheduler/blob/0464123c2b8d507a16a966e2dbe8dbfe9bf781e2/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java#L277-L279



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org