You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2015/07/01 19:40:32 UTC
Re: Review Request 35928: Avoid unintentional use of TaskStatus.Reason
default value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35928/#review90073
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On July 1, 2015, 10:30 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35928/
> -----------------------------------------------------------
>
> (Updated July 1, 2015, 10:30 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1327
> https://issues.apache.org/jira/browse/AURORA-1327
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Avoid unintentional use of TaskStatus.Reason default value.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 33749de538e9a6e08f6ec640ee44f8a5d74256e0
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java f08c79932f2ff9ed64b273a432c7d33c05ad95bd
>
> Diff: https://reviews.apache.org/r/35928/diff/
>
>
> Testing
> -------
>
> The test methodology here is not great (though it's no worse than the original). For all intents and purposes, the test code is a carbon copy of the application code. Open to ideas, i couldn't quickly come up with anything obviously better.
>
>
> Thanks,
>
> Bill Farner
>
>