[GitHub] [hadoop] steveloughran commented on a diff in pull request #4809: HADOOP-18424. Fix org.apache.hadoop.io.ArrayWritable

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on code in PR #4809:
URL: https://github.com/apache/hadoop/pull/4809#discussion_r1175269165


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestArrayWritable.java:
##########
@@ -101,5 +108,29 @@ public void testArrayWritableStringConstructor() {
     assertArrayEquals("testArrayWritableStringConstructor toString error!!!",
       original, arrayWritable.toStrings());
   }
+
+  @Test
+  public void testArrayWritableStrings() throws Exception {
+    String[] original = {"The 1896 Cedar Keys hurricane was a powerful tropical cyclone " +

Review Comment:
   don't think we should be using wikipedia text even if it's interesting. just use something from our own docs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org