[GitHub] [spark] liang3zy22 commented on pull request #40657: [SPARK-42844][SQL]Update error_class "_LEGACY_ERROR_TEMP_2008" to "INVALID_URL_STRING"

["liang3zy22 (via GitHub)" <gi...@apache.org>]

liang3zy22 commented on PR #40657:
URL: https://github.com/apache/spark/pull/40657#issuecomment-1496046743

   @MaxGekk , I have updated the PR for all your review except the "Could you trigger the error from user code, please. For example sql("select parse_url(...)")".
   I can't use sql function in StringExpressionsSuite.scala, don't know how to import the sql function. 
   I have tried in UrlFunctionsSuite.scala using sql function. The test result reported:
   ```
   [info] - url parse_url function *** FAILED *** (3 seconds, 922 milliseconds)
   [info]   Expected exception org.apache.spark.SparkIllegalArgumentException to be thrown, but no exception was thrown (UrlFunctionsSuite.scala:75)
   ```  
   
   Actually I firstly added test case in UrlFunctionSuite like I do now.scala to try to get the error, but I failed. I have tried to assign the sql code result to a variable and then call show method. The test case reported following error:
   ```
   [info] - url parse_url function *** FAILED *** (4 seconds, 65 milliseconds)
   [info]   Expected exception org.apache.spark.SparkIllegalArgumentException to be thrown, but org.apache.spark.SparkException was thrown (UrlFunctionsSuite.scala:75)
   ```
   
   Then I found StringExpressionsSuite.scala and tried in it. The error can be reproduced. So I don't know it can't be reproduced from user space or my method is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org