You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/08/03 17:42:45 UTC

[GitHub] [sling-org-apache-sling-discovery-base] artem-smotrakov opened a new pull request #5: SLING-10700: Improve TopologyRequestValidator code

artem-smotrakov opened a new pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5


   This addresses https://issues.apache.org/jira/browse/SLING-10700


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892747074


   Thanks @artem-smotrakov for the PR. It looks good to me. 
   
   One question regarding your comment on the jira:
   
   >  To be on the safer side, it may be better to set a random IV explicitly.
   
   IIUC you ultimately decided not to change the IV - so from that I'm assuming you are fine with the current code in that regard?
   
   @ieb , IIRC you were involved in this code, would you like to review this PR as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli merged pull request #5: SLING-10700: Improve TopologyRequestValidator code

Posted by GitBox <gi...@apache.org>.
stefan-egli merged pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] artem-smotrakov commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

Posted by GitBox <gi...@apache.org>.
artem-smotrakov commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892790372


   > One question regarding your comment on the jira:
   > 
   > > To be on the safer side, it may be better to set a random IV explicitly.
   > 
   > IIUC you ultimately decided not to change the IV - so from that I'm assuming you are fine with the current code in that regard?
   
   I think it should be okay to rely on the behavior of security-libs in Java. I've tested it with the latest JDK 8u -- the IV looks random.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] stefan-egli commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

Posted by GitBox <gi...@apache.org>.
stefan-egli commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892747074


   Thanks @artem-smotrakov for the PR. It looks good to me. 
   
   One question regarding your comment on the jira:
   
   >  To be on the safer side, it may be better to set a random IV explicitly.
   
   IIUC you ultimately decided not to change the IV - so from that I'm assuming you are fine with the current code in that regard?
   
   @ieb , IIRC you were involved in this code, would you like to review this PR as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-discovery-base] artem-smotrakov commented on pull request #5: SLING-10700: Improve TopologyRequestValidator code

Posted by GitBox <gi...@apache.org>.
artem-smotrakov commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-discovery-base/pull/5#issuecomment-892790372


   > One question regarding your comment on the jira:
   > 
   > > To be on the safer side, it may be better to set a random IV explicitly.
   > 
   > IIUC you ultimately decided not to change the IV - so from that I'm assuming you are fine with the current code in that regard?
   
   I think it should be okay to rely on the behavior of security-libs in Java. I've tested it with the latest JDK 8u -- the IV looks random.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org