You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by im...@apache.org on 2021/05/26 23:43:33 UTC

[asterixdb] 27/38: [NO ISSUE][TX] Ensure lock manager computes valid indexes for hash table

This is an automated email from the ASF dual-hosted git repository.

imaxon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/asterixdb.git

commit ed56b863625ec6e9ed05ca58e13329e332ebe457
Author: Ali Alsuliman <al...@gmail.com>
AuthorDate: Mon May 10 19:53:45 2021 +0300

    [NO ISSUE][TX] Ensure lock manager computes valid indexes for hash table
    
    - user model changes: no
    - storage format changes: no
    - interface changes: no
    
    Details:
    Given a dataset id and an entity hash value, ensure that the lock
    manager computes a valid index for looking up the hash table.
    
    Change-Id: I33d342455a79d0d69b49e126ff6a40c47b07d0dd
    Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/11403
    Reviewed-by: Ali Alsuliman <al...@gmail.com>
    Reviewed-by: Michael Blow <mb...@apache.org>
    Tested-by: Michael Blow <mb...@apache.org>
    Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
    Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
 .../transaction/management/service/locking/ResourceGroupTable.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java
index 93cda83..a82b302 100644
--- a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java
+++ b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/locking/ResourceGroupTable.java
@@ -41,7 +41,7 @@ class ResourceGroupTable {
 
     ResourceGroup get(int dId, int entityHashValue) {
         // TODO ensure good properties of hash function
-        return table[Math.abs(dId ^ entityHashValue) % size];
+        return table[Math.abs((dId ^ entityHashValue) % size)];
     }
 
     ResourceGroup get(int i) {