You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 10:33:17 UTC

[GitHub] [spark] zero323 commented on a change in pull request #34318: [SPARK-37048][PYTHON] Clean up inlining type hints under SQL module

zero323 commented on a change in pull request #34318:
URL: https://github.com/apache/spark/pull/34318#discussion_r731725016



##########
File path: python/pyspark/sql/observation.py
##########
@@ -14,17 +14,16 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-from typing import Any, Dict, Optional, TYPE_CHECKING
+from typing import Any, Dict, Optional
+
+from py4j.java_gateway import JavaObject, JVMView

Review comment:
       Don't we need ignore here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org