You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2023/05/31 12:18:39 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
grundprinzip opened a new pull request, #41403:
URL: https://github.com/apache/spark/pull/41403
### What changes were proposed in this pull request?
This patch adds the golang package path to the proto files to be consumed from the golang repo.
### Why are the changes needed?
Preparation for the go client.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No functional change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #41403:
URL: https://github.com/apache/spark/pull/41403#discussion_r1212033227
##########
connector/connect/common/src/main/protobuf/buf.yaml:
##########
@@ -18,6 +18,8 @@ version: v1
breaking:
use:
- FILE
+ except:
+ - FILE_SAME_GO_PACKAGE
Review Comment:
Can I ask why we are excepting this? Proto is shared for every client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang closed pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
URL: https://github.com/apache/spark/pull/41403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "gengliangwang (via GitHub)" <gi...@apache.org>.
gengliangwang commented on PR #41403:
URL: https://github.com/apache/spark/pull/41403#issuecomment-1570886695
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on PR #41403:
URL: https://github.com/apache/spark/pull/41403#issuecomment-1570205054
This trips the breaking change detection because the previous go package path was empty. However, this is not an issue because we don't have a go client as of right now.
<img width="623" alt="image" src="https://github.com/apache/spark/assets/3421/42779439-9902-4f15-acfc-aefbce9988df">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #41403:
URL: https://github.com/apache/spark/pull/41403#discussion_r1212076040
##########
connector/connect/common/src/main/protobuf/buf.yaml:
##########
@@ -18,6 +18,8 @@ version: v1
breaking:
use:
- FILE
+ except:
+ - FILE_SAME_GO_PACKAGE
Review Comment:
As you can see above without this option it will be a breaking change compared to the 3.4 release. Since we don't have a go client right now it's acceptable. Once we have the go client and a new release we can remove this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #41403:
URL: https://github.com/apache/spark/pull/41403#discussion_r1212081988
##########
connector/connect/common/src/main/protobuf/buf.yaml:
##########
@@ -18,6 +18,8 @@ version: v1
breaking:
use:
- FILE
+ except:
+ - FILE_SAME_GO_PACKAGE
Review Comment:
Ah I see this is to compare with previous release. Thanks for the clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org