You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Lav Jain <lj...@pivotal.io> on 2016/02/12 03:21:24 UTC
Review Request 43511: Refactor HAWQ common.py after moving config
substitution to UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43511/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-15019
https://issues.apache.org/jira/browse/AMBARI-15019
Repository: ambari
Description
-------
Use partial function for XmlConfig. Functions __update_yarn_client, __update_hawq_site, __update_hdfs_client may no longer be required.
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 23342f5
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63
Diff: https://reviews.apache.org/r/43511/diff/
Testing
-------
Tested manually.
Thanks,
Lav Jain
Re: Review Request 43511: Refactor HAWQ common.py after moving config
substitution to UI
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43511/#review118982
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Denissov
On Feb. 12, 2016, 2:21 a.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43511/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2016, 2:21 a.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15019
> https://issues.apache.org/jira/browse/AMBARI-15019
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Use partial function for XmlConfig. Functions __update_yarn_client, __update_hawq_site, __update_hdfs_client may no longer be required.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 23342f5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63
>
> Diff: https://reviews.apache.org/r/43511/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 43511: Refactor HAWQ common.py after moving config
substitution to UI
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43511/#review118979
-----------------------------------------------------------
Ship it!
Ship It!
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 70)
<https://reviews.apache.org/r/43511/#comment180283>
The comment about 'append related parameters' is obsolete.
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 75)
<https://reviews.apache.org/r/43511/#comment180282>
The comment about 'append related parameters' is obsolete.
- Matt
On Feb. 11, 2016, 6:21 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43511/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 6:21 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, Jaimin Jetly, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-15019
> https://issues.apache.org/jira/browse/AMBARI-15019
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Use partial function for XmlConfig. Functions __update_yarn_client, __update_hawq_site, __update_hdfs_client may no longer be required.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 23342f5
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py add3c63
>
> Diff: https://reviews.apache.org/r/43511/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>