[GitHub] shuaijunlan opened a new issue #2547: Logical Error in ForkingClusterInvoker?

[GitBox <gi...@apache.org>]

shuaijunlan opened a new issue #2547: Logical Error in ForkingClusterInvoker?
URL: https://github.com/apache/incubator-dubbo/issues/2547
 
 
   - [x] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
   - [x] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
   
   ### Environment
   
   * Dubbo version: 2.7.0-SNAPSHOT
   ### Steps to reproduce this issue
   
   [Source code Fragment](https://github.com/apache/incubator-dubbo/blob/7f926d9991ba69dba25b56925e4cc5ffcdf50afa/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java#L68-L75):
   ```java
   for (int i = 0; i < forks; i++) {
       // TODO. Add some comment here, refer chinese version for more details.
       Invoker<T> invoker = select(loadbalance, invocation, invokers, selected);
       if (!selected.contains(invoker)) {
           //Avoid add the same invoker several times.
           selected.add(invoker);
       }
   }
   ```
   When `selected list` contains invoker, it will continue loop, it may result in the size of `selected list` less than `forks`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org