You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2024/03/01 09:20:18 UTC
[PR] [Feature](topn) support multiple topn filter on backend [doris]
BiteTheDDDDt opened a new pull request, #31665:
URL: https://github.com/apache/doris/pull/31665
## Proposed changes
support multiple topn filter on backend
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #31665:
URL: https://github.com/apache/doris/pull/31665#discussion_r1509206909
##########
be/src/runtime/query_context.h:
##########
@@ -148,7 +148,19 @@ class QueryContext {
return _shared_scanner_controller;
}
- vectorized::RuntimePredicate& get_runtime_predicate() { return _runtime_predicate; }
+ vectorized::RuntimePredicate& get_runtime_predicate(int source_node_id) {
Review Comment:
warning: method 'get_runtime_predicate' can be made static [readability-convert-member-functions-to-static]
```suggestion
static vectorized::RuntimePredicate& get_runtime_predicate(int source_node_id) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1976048785
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972987458
<details>
<summary>TPC-DS: <b>Total hot run time: 188213 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3d3e4c120a6734461d4ac77217ed850489894413, data reload: false
query1 1041 393 393 393
query2 7894 2361 2331 2331
query3 6727 297 308 297
query4 23535 22025 24411 22025
query5 5684 862 4148 862
query6 526 292 292 292
query7 4926 453 467 453
query8 297 252 270 252
query9 8698 3428 3397 3397
query10 558 334 340 334
query11 19739 19988 19720 19720
query12 369 276 232 232
query13 1714 666 660 660
query14 11756 7721 7471 7471
query15 342 242 262 242
query16 8370 395 392 392
query17 2146 678 661 661
query18 2170 460 384 384
query19 460 230 237 230
query20 145 141 134 134
query21 234 172 161 161
query22 5435 5133 4984 4984
query23 24751 24908 24981 24908
query24 5966 2068 2068 2068
query25 612 502 506 502
query26 781 226 228 226
query27 1952 487 503 487
query28 3205 2813 2798 2798
query29 942 774 769 769
query30 322 199 218 199
query31 1388 809 833 809
query32 128 96 92 92
query33 625 382 380 380
query34 863 649 665 649
query35 983 892 871 871
query36 1248 1139 1170 1139
query37 133 109 107 107
query38 3251 3172 3124 3124
query39 1161 1084 1118 1084
query40 244 167 165 165
query41 94 86 90 86
query42 160 170 158 158
query43 590 576 597 576
query44 1260 1057 1065 1057
query45 231 216 215 215
query46 888 786 784 784
query47 1714 1706 1727 1706
query48 592 528 519 519
query49 736 474 484 474
query50 652 549 551 549
query51 9264 8794 8897 8794
query52 153 140 141 140
query53 330 323 322 322
query54 379 348 355 348
query55 160 123 137 123
query56 403 348 339 339
query57 1100 1040 1057 1040
query58 356 326 336 326
query59 3622 3385 3348 3348
query60 397 389 380 380
query61 170 165 165 165
query62 509 422 417 417
query63 320 335 339 335
query64 4239 1846 1839 1839
query65 2374 2323 2400 2323
query66 901 400 382 382
query67 16154 15201 15336 15201
query68 4223 696 711 696
query69 655 555 568 555
query70 1595 1575 1587 1575
query71 470 423 411 411
query72 2855 2337 2373 2337
query73 657 483 482 482
query74 7115 7466 7383 7383
query75 3113 2868 2814 2814
query76 2074 634 640 634
query77 476 415 403 403
query78 6995 6267 6403 6267
query79 1072 775 743 743
query80 687 597 583 583
query81 481 261 253 253
query82 163 137 141 137
query83 260 238 227 227
query84 274 130 120 120
query85 837 535 513 513
query86 438 444 420 420
query87 3565 3285 3264 3264
query88 3715 3487 3470 3470
query89 453 409 423 409
query90 921 229 234 229
query91 204 201 202 201
query92 84 84 84 84
query93 1028 722 692 692
query94 473 277 273 273
query95 581 520 536 520
query96 632 387 389 387
query97 2969 2891 2822 2822
query98 318 296 294 294
query99 840 787 785 785
Total cold run time: 259292 ms
Total hot run time: 188213 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972970176
<details>
<summary>TPC-H: <b>Total hot run time: 32135 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3d3e4c120a6734461d4ac77217ed850489894413, data reload: false
------ Round 1 ----------------------------------
q1 17744 4635 4473 4473
q2 2165 227 213 213
q3 10389 1119 1108 1108
q4 4702 1211 1210 1210
q5 7662 2093 2054 2054
q6 154 108 104 104
q7 1179 1094 1073 1073
q8 9488 1079 1090 1079
q9 6262 5012 4848 4848
q10 7855 2049 1976 1976
q11 533 320 318 318
q12 844 426 426 426
q13 18026 2874 2963 2874
q14 317 299 303 299
q15 395 365 348 348
q16 534 503 524 503
q17 750 312 315 312
q18 5845 4949 4740 4740
q19 1169 407 408 407
q20 585 448 417 417
q21 6135 2907 2899 2899
q22 514 454 464 454
Total cold run time: 103247 ms
Total hot run time: 32135 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4570 4674 4622 4622
q2 296 231 218 218
q3 2222 1917 1914 1914
q4 1655 1337 1379 1337
q5 3348 3062 3011 3011
q6 149 100 111 100
q7 1882 1843 1824 1824
q8 1798 1655 1701 1655
q9 5417 5401 5360 5360
q10 2611 2379 2380 2379
q11 477 418 437 418
q12 775 666 694 666
q13 3135 2678 2672 2672
q14 283 262 290 262
q15 366 349 343 343
q16 497 487 500 487
q17 1105 774 770 770
q18 6128 5691 5328 5328
q19 1094 646 638 638
q20 1613 1442 1484 1442
q21 4833 4328 4338 4328
q22 701 618 594 594
Total cold run time: 44955 ms
Total hot run time: 40368 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1975072297
TeamCity be ut coverage result:
Function Coverage: 35.42% (8554/24147)
Line Coverage: 27.19% (69404/255275)
Region Coverage: 26.40% (36002/136363)
Branch Coverage: 23.24% (18392/79126)
Coverage Report: http://coverage.selectdb-in.cc/coverage/de0d9487120c68110ca6800d9223b93e8b24add4_de0d9487120c68110ca6800d9223b93e8b24add4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972980315
TeamCity be ut coverage result:
Function Coverage: 35.64% (8549/23990)
Line Coverage: 27.44% (69387/252854)
Region Coverage: 26.61% (35999/135300)
Branch Coverage: 23.42% (18395/78534)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3d3e4c120a6734461d4ac77217ed850489894413_3d3e4c120a6734461d4ac77217ed850489894413/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1973101006
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1975646034
TeamCity be ut coverage result:
Function Coverage: 35.42% (8554/24147)
Line Coverage: 27.19% (69412/255275)
Region Coverage: 26.41% (36013/136363)
Branch Coverage: 23.25% (18395/79126)
Coverage Report: http://coverage.selectdb-in.cc/coverage/de0d9487120c68110ca6800d9223b93e8b24add4_de0d9487120c68110ca6800d9223b93e8b24add4/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972863772
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1973116942
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972832653
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972846066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1973437071
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1975052360
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1973187360
TeamCity be ut coverage result:
Function Coverage: 35.49% (8554/24102)
Line Coverage: 27.25% (69408/254731)
Region Coverage: 26.45% (36015/136167)
Branch Coverage: 23.28% (18396/79020)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ba275fa8bfa6ea58646bcde38eaf2f4a7f4f46b_0ba275fa8bfa6ea58646bcde38eaf2f4a7f4f46b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1973592381
TeamCity be ut coverage result:
Function Coverage: 35.48% (8552/24106)
Line Coverage: 27.24% (69390/254763)
Region Coverage: 26.43% (35998/136181)
Branch Coverage: 23.27% (18390/79028)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dade04745f09132889f722ca92b0072b638c157d_dade04745f09132889f722ca92b0072b638c157d/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972815663
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972940336
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1972940383
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #31665:
URL: https://github.com/apache/doris/pull/31665#issuecomment-1975603140
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Feature](topn) support multiple topn filter on backend [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #31665:
URL: https://github.com/apache/doris/pull/31665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org