You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2008/02/12 08:34:08 UTC
[jira] Created: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
[drlvm][signals] New heuristics for crash handler
-------------------------------------------------
Key: HARMONY-5490
URL: https://issues.apache.org/jira/browse/HARMONY-5490
Project: Harmony
Issue Type: Improvement
Components: DRLVM
Reporter: Ilya Berezhniuk
Suggested patch implements new heuristic algorithm for native stack unwinding.
This algorithm enables quite correct stack printing for x86_64 platform.
Internal crash handler interfaces are simplified and improved.
There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
All pre-commit tests are passed for me on 4 platforms.
Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568435#action_12568435 ]
Alexey Varlamov commented on HARMONY-5490:
------------------------------------------
Guys, what is wrong with decoder asserts? You've commented them out w/o commenting.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568860#action_12568860 ]
Alexey Varlamov commented on HARMONY-5490:
------------------------------------------
Sure, I just wanted to dispel possible confusion in future.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583966#action_12583966 ]
Ilya Berezhniuk commented on HARMONY-5490:
------------------------------------------
As I expected, HARMONY-5495 breaks native stack unwinding, because it adds assertions in case of incorrect prefix sequence.
I opened HARMONY-5673 for this problem, so this issue may be finally closed.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5490:
-------------------------------------
Attachment: lnx_x86_64_debug.txt
lnx_x86_debug.txt
ch_proto_38.patch
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-5490:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568445#action_12568445 ]
Ilya Berezhniuk commented on HARMONY-5490:
------------------------------------------
I think these asserts were used for debugging the decoder itself, and only JITted code was parsed.
Now decoder is stable, and decoder is used for parsing native code.
When decoding native code from a native compiler, error code should be returned instead of assertion - native code can include unknown constructs, or even wrong/corrupted instructions.
This is the case in current native stack unwinding algorithm: when looking for return address in stack, it tries to decode CALL instruction with several offsets behind the return address.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk closed HARMONY-5490.
------------------------------------
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567991#action_12567991 ]
Ilya Berezhniuk commented on HARMONY-5490:
------------------------------------------
Tests on Linux/IPF are also passed for me in interpreter mode.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568815#action_12568815 ]
Alexey Varlamov commented on HARMONY-5490:
------------------------------------------
When better just drop them? Or if they may still appear useful, ifdef them?
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5490) [drlvm][signals] New heuristics
for crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568834#action_12568834 ]
Ilya Berezhniuk commented on HARMONY-5490:
------------------------------------------
Thanks Alexey,
I guess it's better to remove them, and check whether calls to decode() check the result.
On the other hand, I'd better wait for HARMONY-5495 to prevent collisions.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5490:
-------------------------------------
Attachment: win_x86_64_debug.txt
win_x86_debug.txt
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5490) [drlvm][signals] New heuristics for
crash handler
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-5490.
----------------------------------------
Resolution: Fixed
Patch is applied at 620872.
> [drlvm][signals] New heuristics for crash handler
> -------------------------------------------------
>
> Key: HARMONY-5490
> URL: https://issues.apache.org/jira/browse/HARMONY-5490
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: ch_proto_38.patch, lnx_x86_64_debug.txt, lnx_x86_debug.txt, win_x86_64_debug.txt, win_x86_debug.txt
>
>
> Suggested patch implements new heuristic algorithm for native stack unwinding.
> This algorithm enables quite correct stack printing for x86_64 platform.
> Internal crash handler interfaces are simplified and improved.
> There is a problem with line information on Windows x86_64 - I'll try to solve this in separate JIRA.
> All pre-commit tests are passed for me on 4 platforms.
> Crash stack examples are attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.