You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Anupam <an...@gmail.com> on 2015/10/16 05:48:44 UTC

Resolving/Closing JIRA issues

I cannot find instructions on what is the usual workflow to resolve/close
JIRA issues either on the Contributing Guide [1] or on the Committer Guide
[2].

I am looking for answers for things like:
 * Who is responsible for resolving a JIRA issue?
 * The committer or the author of the code?
 * Further when do we close an issue and what is the process for that?

-- 
Anupam

[1] https://cwiki.apache.org/confluence/display/REEF/Contributing
[2] https://cwiki.apache.org/confluence/display/REEF/Committer+Guide

RE: Resolving/Closing JIRA issues

Posted by Mariia Mykhailova <ma...@microsoft.com>.
I've added this info to https://cwiki.apache.org/confluence/display/REEF/Committer+Guide

I've also added link to https://cwiki.apache.org/confluence/display/REEF/Windows+PowerShell+Setup which has useful functions for committing pull requests, hopefully this will help new committers

-Mariia

-----Original Message-----
From: Markus Weimer [mailto:markus@weimo.de] 
Sent: Sunday, October 18, 2015 9:03 AM
To: dev@reef.incubator.apache.org
Subject: Re: Resolving/Closing JIRA issues

+1 on defining it for us.

Here's what I've used the two states before: I `resolved` issues whenever I believed them to be closed for good and with a complete outcome (e.g. all needed stuff was implemented). When I `closed` an issue, it meant that it was a WONTFIX or DUPLICATE or such. In other
words: No productive step was taken to close the JIRA.

Markus

Re: Resolving/Closing JIRA issues

Posted by Markus Weimer <ma...@weimo.de>.
+1 on defining it for us.

Here's what I've used the two states before: I `resolved` issues 
whenever I believed them to be closed for good and with a complete 
outcome (e.g. all needed stuff was implemented). When I `closed` an 
issue, it meant that it was a WONTFIX or DUPLICATE or such. In other 
words: No productive step was taken to close the JIRA.

Markus

Re: Resolving/Closing JIRA issues

Posted by Dongjoon Hyun <do...@apache.org>.
+1 for adding clear definitions to our committer guide.
By the way, can we make that as simple as possible to save our efforts?

Warmly,
Dongjoon.

On Sat, Oct 17, 2015 at 7:58 AM, Byung-Gon Chun <bg...@gmail.com> wrote:

> That's a great question.
> We haven't formally defined Resolved and Closed states. It would be great
> to iron this out.
> Different groups have different ways of interpreting them.
> http://stackoverflow.com/questions/4718471/jira-to-close-or-to-resolve
>
>
> On Sat, Oct 17, 2015 at 5:37 AM, Anupam <an...@gmail.com> wrote:
>
> > +1 for adding to Committer Guide.
> >
> > Essentially my question is, do we differentiate between Resolved and
> > Closed? Should we? How?
> >
> > On 16 October 2015 at 00:31, Markus Weimer <ma...@weimo.de> wrote:
> >
> > > On 2015-10-15 20:51, Byung-Gon Chun wrote:
> > > > In most cases, the person who merges a PR that addresses a JIRA issue
> > can
> > > > resolve the JIRA issue.
> > >
> > > Agreed. But Anupam has a point: We never actually wrote down that bit
> of
> > > our day to day work. Would be a good addition to the committer guide,
> > > including instructions about which version to add to the JIRA when.
> > >
> > > > On Fri, Oct 16, 2015 at 12:48 PM, Anupam <an...@gmail.com>
> wrote:
> > > >>  * Further when do we close an issue and what is the process for
> that?
> > >
> > > That is very ad-hoc. I've closed issues after we've discovered they
> were
> > > non-sensical or when I found another JIRA that duplicates one. Other
> > > than that, we sometimes have comments on them whether or not to close
> > > them now.
> > >
> > > This is not a very good process, as we will accumulate lots of JIRAs
> > > that noone actively looks at. Many OSS projects suffer the same JIRA
> > > aggregation. I am not sure whether we even should do something about
> it.
> > > A large number of open JIRAs by itself is not bad, unless it prevents
> us
> > > from keeping track of things.
> > >
> > > Markus
> > >
> >
> >
> >
> > --
> > Anupam
> > Bellevue, WA
> > Ph: +1 (425)-777-5570
> >
>
>
>
> --
> Byung-Gon Chun
>

Re: Resolving/Closing JIRA issues

Posted by Byung-Gon Chun <bg...@gmail.com>.
That's a great question.
We haven't formally defined Resolved and Closed states. It would be great
to iron this out.
Different groups have different ways of interpreting them.
http://stackoverflow.com/questions/4718471/jira-to-close-or-to-resolve


On Sat, Oct 17, 2015 at 5:37 AM, Anupam <an...@gmail.com> wrote:

> +1 for adding to Committer Guide.
>
> Essentially my question is, do we differentiate between Resolved and
> Closed? Should we? How?
>
> On 16 October 2015 at 00:31, Markus Weimer <ma...@weimo.de> wrote:
>
> > On 2015-10-15 20:51, Byung-Gon Chun wrote:
> > > In most cases, the person who merges a PR that addresses a JIRA issue
> can
> > > resolve the JIRA issue.
> >
> > Agreed. But Anupam has a point: We never actually wrote down that bit of
> > our day to day work. Would be a good addition to the committer guide,
> > including instructions about which version to add to the JIRA when.
> >
> > > On Fri, Oct 16, 2015 at 12:48 PM, Anupam <an...@gmail.com> wrote:
> > >>  * Further when do we close an issue and what is the process for that?
> >
> > That is very ad-hoc. I've closed issues after we've discovered they were
> > non-sensical or when I found another JIRA that duplicates one. Other
> > than that, we sometimes have comments on them whether or not to close
> > them now.
> >
> > This is not a very good process, as we will accumulate lots of JIRAs
> > that noone actively looks at. Many OSS projects suffer the same JIRA
> > aggregation. I am not sure whether we even should do something about it.
> > A large number of open JIRAs by itself is not bad, unless it prevents us
> > from keeping track of things.
> >
> > Markus
> >
>
>
>
> --
> Anupam
> Bellevue, WA
> Ph: +1 (425)-777-5570
>



-- 
Byung-Gon Chun

Re: Resolving/Closing JIRA issues

Posted by Anupam <an...@gmail.com>.
+1 for adding to Committer Guide.

Essentially my question is, do we differentiate between Resolved and
Closed? Should we? How?

On 16 October 2015 at 00:31, Markus Weimer <ma...@weimo.de> wrote:

> On 2015-10-15 20:51, Byung-Gon Chun wrote:
> > In most cases, the person who merges a PR that addresses a JIRA issue can
> > resolve the JIRA issue.
>
> Agreed. But Anupam has a point: We never actually wrote down that bit of
> our day to day work. Would be a good addition to the committer guide,
> including instructions about which version to add to the JIRA when.
>
> > On Fri, Oct 16, 2015 at 12:48 PM, Anupam <an...@gmail.com> wrote:
> >>  * Further when do we close an issue and what is the process for that?
>
> That is very ad-hoc. I've closed issues after we've discovered they were
> non-sensical or when I found another JIRA that duplicates one. Other
> than that, we sometimes have comments on them whether or not to close
> them now.
>
> This is not a very good process, as we will accumulate lots of JIRAs
> that noone actively looks at. Many OSS projects suffer the same JIRA
> aggregation. I am not sure whether we even should do something about it.
> A large number of open JIRAs by itself is not bad, unless it prevents us
> from keeping track of things.
>
> Markus
>



-- 
Anupam
Bellevue, WA
Ph: +1 (425)-777-5570

Re: Resolving/Closing JIRA issues

Posted by Markus Weimer <ma...@weimo.de>.
On 2015-10-15 20:51, Byung-Gon Chun wrote:
> In most cases, the person who merges a PR that addresses a JIRA issue can
> resolve the JIRA issue.

Agreed. But Anupam has a point: We never actually wrote down that bit of
our day to day work. Would be a good addition to the committer guide,
including instructions about which version to add to the JIRA when.

> On Fri, Oct 16, 2015 at 12:48 PM, Anupam <an...@gmail.com> wrote:
>>  * Further when do we close an issue and what is the process for that?

That is very ad-hoc. I've closed issues after we've discovered they were
non-sensical or when I found another JIRA that duplicates one. Other
than that, we sometimes have comments on them whether or not to close
them now.

This is not a very good process, as we will accumulate lots of JIRAs
that noone actively looks at. Many OSS projects suffer the same JIRA
aggregation. I am not sure whether we even should do something about it.
A large number of open JIRAs by itself is not bad, unless it prevents us
from keeping track of things.

Markus

Re: Resolving/Closing JIRA issues

Posted by Byung-Gon Chun <bg...@gmail.com>.
Hi Anupam,

In most cases, the person who merges a PR that addresses a JIRA issue can
resolve the JIRA issue.
I think this rule has worked well.

Thanks.
-Gon


On Fri, Oct 16, 2015 at 12:48 PM, Anupam <an...@gmail.com> wrote:

> I cannot find instructions on what is the usual workflow to resolve/close
> JIRA issues either on the Contributing Guide [1] or on the Committer Guide
> [2].
>
> I am looking for answers for things like:
>  * Who is responsible for resolving a JIRA issue?
>  * The committer or the author of the code?
>  * Further when do we close an issue and what is the process for that?
>
> --
> Anupam
>
> [1] https://cwiki.apache.org/confluence/display/REEF/Contributing
> [2] https://cwiki.apache.org/confluence/display/REEF/Committer+Guide
>



-- 
Byung-Gon Chun