[GitHub] [iotdb] MiniSho commented on a diff in pull request #7620: [IOTDB-4644] Support modifying DataNode's IP:Port

[GitBox <gi...@apache.org>]

MiniSho commented on code in PR #7620:
URL: https://github.com/apache/iotdb/pull/7620#discussion_r1003935645


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/node/NodeManager.java:
##########
@@ -293,6 +294,35 @@ public DataSet removeDataNode(RemoveDataNodePlan removeDataNodePlan) {
     return dataSet;
   }
 
+  /**
+   * Update DataNode
+   *
+   * @param updateDataNodePlan UpdateDataNodePlan
+   * @return TSStatus. The TSStatus will be set to SUCCESS_STATUS when update success, and
+   *     DATANODE_NOT_EXIST when some datanode is not exist, UPDATE_DATANODE_FAILED when update
+   *     failed.
+   */
+  public TSStatus updateDataNode(UpdateDataNodePlan updateDataNodePlan) {
+    LOGGER.info("NodeManager start to update DataNode {}", updateDataNodePlan);
+
+    // check if node is already exist
+    boolean found = false;
+    List<TDataNodeConfiguration> configurationList = getRegisteredDataNodes();
+    for (TDataNodeConfiguration configuration : configurationList) {
+      if (configuration.getLocation().getDataNodeId()
+          == updateDataNodePlan.getDataNodeLocation().getDataNodeId()) {
+        found = true;
+        break;
+      }
+    }
+    if (found) {
+      getConsensusManager().write(updateDataNodePlan);
+      return nodeInfo.updateDataNode(updateDataNodePlan);
+    } else {
+      return new TSStatus(TSStatusCode.DATANODE_NOT_EXIST.getStatusCode());

Review Comment:
   fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org