You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by "Scott Anderson (JIRA)" <de...@cayenne.apache.org> on 2008/09/15 17:07:11 UTC
[jira] Created: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
[PATCH] MySQL/DbMerger compatibility
------------------------------------
Key: CAY-1108
URL: https://issues.apache.org/cayenne/browse/CAY-1108
Project: Cayenne
Issue Type: Improvement
Components: Cayenne Core Library
Affects Versions: 3.0
Reporter: Scott Anderson
Assignee: Andrus Adamchik
This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Tore Halset (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105#action_13105 ]
Tore Halset commented on CAY-1108:
----------------------------------
I have added the SetNotNullToDb-MySQL.patch. Thanks Scott!
I have not added the increase_reuse.patch as that would make SetColumnTypeToDb and AddColumnToDb include the "not null" clause. We need not null to be a separate token to be able to add a default value after the column is added, but before setting not null.
Please report back if this is ok Scott!
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Attachments: increase_reuse.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Scott Anderson (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Anderson updated CAY-1108:
--------------------------------
Attachment: SetNotNullToDb-MySQL.patch
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Andrus Adamchik
> Attachments: increase_reuse.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Tore Halset (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tore Halset closed CAY-1108.
----------------------------
Resolution: Fixed
Fix Version/s: 3.0
I think this one is fixed and it is included in the release notes.
The code reuse patch is not included yet as I do not think it is related to this issue. If it is important to make merging work on MySQL, then please reopen or create a new issue.
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Fix For: 3.0
>
> Attachments: increase_reuse.patch, increase_reuse2.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAY-1108) [PATCH] MySQL/DbMerger
compatibility
Posted by "Dave Dombrosky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126#action_13126 ]
shentalus edited comment on CAY-1108 at 9/29/08 8:00 PM:
--------------------------------------------------------------
Please ignore the encodeAsEJBQL.patch, I accidentally added it to the wrong issue.
was (Author: shentalus):
Uploaded encodeAsEJBQL.patch to fix the issue.
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Fix For: 3.0
>
> Attachments: encodeAsEJBQL.patch, increase_reuse.patch, increase_reuse2.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Andrus Adamchik (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrus Adamchik reassigned CAY-1108:
------------------------------------
Assignee: Tore Halset (was: Andrus Adamchik)
assigning to Tore - he knows best how to handle any of the merger tasks
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Attachments: increase_reuse.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Dave Dombrosky (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Dombrosky updated CAY-1108:
--------------------------------
Attachment: encodeAsEJBQL.patch
Uploaded encodeAsEJBQL.patch to fix the issue.
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Fix For: 3.0
>
> Attachments: encodeAsEJBQL.patch, increase_reuse.patch, increase_reuse2.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Scott Anderson (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Anderson updated CAY-1108:
--------------------------------
Attachment: increase_reuse2.patch
What an oversight!
Try this one out for size.
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Tore Halset
> Attachments: increase_reuse.patch, increase_reuse2.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAY-1108) [PATCH] MySQL/DbMerger compatibility
Posted by "Scott Anderson (JIRA)" <de...@cayenne.apache.org>.
[ https://issues.apache.org/cayenne/browse/CAY-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Anderson updated CAY-1108:
--------------------------------
Attachment: increase_reuse.patch
Increase the reuse of code
> [PATCH] MySQL/DbMerger compatibility
> ------------------------------------
>
> Key: CAY-1108
> URL: https://issues.apache.org/cayenne/browse/CAY-1108
> Project: Cayenne
> Issue Type: Improvement
> Components: Cayenne Core Library
> Affects Versions: 3.0
> Reporter: Scott Anderson
> Assignee: Andrus Adamchik
> Attachments: increase_reuse.patch, SetNotNullToDb-MySQL.patch
>
>
> This patch will generate proper SQL for changing a MySQL field to NOT NULL
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.