You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org> on 2012/06/07 07:39:23 UTC
[jira] [Created] (FLUME-1260) Create separate nondefault build
profile for rat
Jarek Jarcec Cecho created FLUME-1260:
-----------------------------------------
Summary: Create separate nondefault build profile for rat
Key: FLUME-1260
URL: https://issues.apache.org/jira/browse/FLUME-1260
Project: Flume
Issue Type: Improvement
Components: Build
Reporter: Jarek Jarcec Cecho
Priority: Minor
I see many people having issues with rat check during build lately (including myself) which can be seen as a barrier for new contributors.
I would like to suggest moving execution of rat into separate build profile that won't be run by default. This new profile would be then used for continuous integration and during release procedure.
Jarcec
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1260) Create separate nondefault build
profile for rat
Posted by "Juhani Connolly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290829#comment-13290829 ]
Juhani Connolly commented on FLUME-1260:
----------------------------------------
Perhaps skipping rat could be rolled into -DskipTests which is commonly recommended to people wanting to try out the trunk? I think needing to proactively switch rat testing on would result in patches slipping through without licenses attached and thus failures
> Create separate nondefault build profile for rat
> ------------------------------------------------
>
> Key: FLUME-1260
> URL: https://issues.apache.org/jira/browse/FLUME-1260
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Reporter: Jarek Jarcec Cecho
> Priority: Minor
>
> I see many people having issues with rat check during build lately (including myself) which can be seen as a barrier for new contributors.
> I would like to suggest moving execution of rat into separate build profile that won't be run by default. This new profile would be then used for continuous integration and during release procedure.
> Jarcec
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLUME-1260) Create separate nondefault build
profile for rat
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jarek Jarcec Cecho resolved FLUME-1260.
---------------------------------------
Resolution: Invalid
Thank you guys for your input. There is obviously huge disagreement with the idea, so I'll simply close this JIRA.
> Create separate nondefault build profile for rat
> ------------------------------------------------
>
> Key: FLUME-1260
> URL: https://issues.apache.org/jira/browse/FLUME-1260
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Reporter: Jarek Jarcec Cecho
> Priority: Minor
>
> I see many people having issues with rat check during build lately (including myself) which can be seen as a barrier for new contributors.
> I would like to suggest moving execution of rat into separate build profile that won't be run by default. This new profile would be then used for continuous integration and during release procedure.
> Jarcec
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-1260) Create separate nondefault build
profile for rat
Posted by "Hari Shreedharan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290854#comment-13290854 ]
Hari Shreedharan commented on FLUME-1260:
-----------------------------------------
I don't agree with having a build profile for rat. The reason as I posted on FLUME-1202 is:
If we move it to a different profile, we might end up committing code without these licenses. It is important that we don't do that. It is easy to miss the fact that there is no license on a new file, during the review. But there is no way you can miss a build failure due to missing license
So even if the contributor misses the licenses, the reviewer is not going to miss it when he builds for review. Trust me, people will forget to do a separate build for rat!
> Create separate nondefault build profile for rat
> ------------------------------------------------
>
> Key: FLUME-1260
> URL: https://issues.apache.org/jira/browse/FLUME-1260
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Reporter: Jarek Jarcec Cecho
> Priority: Minor
>
> I see many people having issues with rat check during build lately (including myself) which can be seen as a barrier for new contributors.
> I would like to suggest moving execution of rat into separate build profile that won't be run by default. This new profile would be then used for continuous integration and during release procedure.
> Jarcec
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira