You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/05 10:35:42 UTC

[GitHub] [skywalking-website] libinglong edited a comment on pull request #209: Propagate trace when using ThreadPoolExecutor

libinglong edited a comment on pull request #209:
URL: https://github.com/apache/skywalking-website/pull/209#issuecomment-773933431


   
   
   
   > Several things I want to highlight
   > 
   > 1. You should use the words `propagate context` or `continue trace`. `Propagate trace` is strange.
   > 2. You are inviting people to use your project, then you need to make sure your project is under friendly Open Source License, please choose one.
   > 3. I noticed `com.lbl` in your package name, which company or entity do you actually mean? Do you already have the SGA in the license you are going to use?
   
   change propagate trace to propagate context
   change com.lbl to net.bird
   I have added the apache 2.0 license.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org