You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/08/19 07:16:03 UTC
[GitHub] matthiasblaesing commented on a change in pull request #717:
[NETBEANS-1074] Module Review groovy.support
matthiasblaesing commented on a change in pull request #717: [NETBEANS-1074] Module Review groovy.support
URL: https://github.com/apache/incubator-netbeans/pull/717#discussion_r211094283
##########
File path: nbbuild/rat-exclusions.txt
##########
@@ -36,6 +36,7 @@ nbbuild/user.build.properties
**/Makefile-vc
**/Makefile-vc-wo-crt
**/package-list
+groovy.support/src/META-INF.debugger*/**
Review comment:
This is IMHO not needed. If I'm not mistaken the code, that reads the files is `api.debugger/src/org/netbeans/api/debugger/Lookup.java` and there comment sign `#` is explicitly mentioned, so I would add the ALv2 header directly. There are also debugger related files `spi.debugger.ui/build/classes/META-INF/debugger/ThreadsView/org.netbeans.spi.viewmodel.ColumnModel` that show the header.
So I would not add it to the exlusion list, but add the header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists