You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "George Jempty (JIRA)" <ji...@apache.org> on 2006/07/06 02:29:16 UTC
[jira] Created: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
MappingDispatchAction throws an error when mapping.getParameter returns null
----------------------------------------------------------------------------
Key: STR-2903
URL: http://issues.apache.org/struts/browse/STR-2903
Project: Struts 1
Type: Bug
Versions: 1.2.9
Environment: Windows/Tomcat
Reporter: George Jempty
The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
public ActionForward execute(
ActionMapping mapping,
ActionForm form,
HttpServletRequest request,
HttpServletResponse response)
throws Exception {
// Use the overridden getMethodName.
return super.execute(mapping, form, request, response);
}
Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
HTH
George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=all ]
Ted Husted updated STR-2903:
----------------------------
Component: Extras
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Components: Extras
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.5
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Paul Benedict (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_38881 ]
Paul Benedict commented on STR-2903:
------------------------------------
What is to be done with this ticket? Is there a real code defect to fix or a misunderstanding?
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=all ]
Ted Husted updated STR-2903:
----------------------------
Fix Version: 1.3.5
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.5
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37662 ]
Niall Pemberton commented on STR-2903:
--------------------------------------
So whats wrong with my suggestion of your BaseCCAction extending MappingDisptachAction and overriding the getParameter() method - that seems pretty simple and would then cause unspecified() to be invoked.
Also, my preffered method of correcting the JavaDoc is to simply remove the unspecified() method from MappingDispatchAction - since it does nothing anyway except delegate up to DispatchAction's implementation.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37657 ]
Niall Pemberton commented on STR-2903:
--------------------------------------
I agree with that MappingDispatchAction isn't working the way the JavaDoc describes - however this has been the case since MappingDispatchAction was first in a "GA" Struts release (i.e. Struts 1.2.4). The decision is whether to correct the JavaDoc to reflect current behaviour or change the behaviour to reflect the JavaDoc - IMO I think we should correct the JavaDoc.
If you want your flavour of MappingDispatchAction to exhibit the behaviour described in the JavaDoc then you can simply override the getParameter() method:
protected String getParameter(ActionMapping mapping,
ActionForm form,
HttpServletRequest request,
HttpServletResponse response) throws Exception {
return mapping.getParameter();
}
(which IMO would also be a better way to correct MappingDispatchAction (rather than the proposed patch) if we were to go the "change the behaviour to reflect the JavaDoc" routine).
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Wendy Smoak (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37659 ]
Wendy Smoak commented on STR-2903:
----------------------------------
I agree with correcting the Javadoc since it has always worked this way.
I came up with: "method which is dispatched to when there is no value for the request parameter named in the ActionMapping's 'parameter' attribute"
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_38893 ]
Niall Pemberton commented on STR-2903:
--------------------------------------
I changed my mind on this - I think we should override the getParameter() method - so that it doesn't throw an exception - which will cause the unspecified() method to get called - any objections?
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37663 ]
George Jempty commented on STR-2903:
------------------------------------
Hey Niall, note that unspecified() is implemented slightly differently in the two classes: they call different keys from the resource bundle.
The REAL issue is that MappingDispatchAction's execute() delegates to DispatchAction's execute, thereby effectively hiding any overriding of getParameter()....the super class will use its own getParameter(). Overriding getParameter() is the right approach, but MappingDispatchAction's overriding of execute() would need to be entirely removed.
Therefore I think I'm just going to override execute() in my BaseAction that extends MappingDispatchAction with my own patch. If MappingDispatchAction didn't override execute(), you're patch would be ideal. Since that is not the case and I would need to modify execute() anyway, probably with a straight cut-and-paste from DispatchAction, and then also override getParameter(), I will just use my patch, without necessity to additionally override getParameter().
Thanks for all your consideration, as far as I'm concerned this issue can be closed.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_38894 ]
George Jempty commented on STR-2903:
------------------------------------
Thanks Niall. I indeed implemented this very suggestion of yours of overriding getParameter() in my own custom Action extending MappingDispatchAction, and what this allowed me to do was to use my existing struts config file with no modifications: I only had to add the parameter attribute to my mappings on an as needed basis. That is the sort of benefit to be gained, and it seems to be a very simple non-invasive code change.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_38884 ]
George Jempty commented on STR-2903:
------------------------------------
Well considering it's been tagged a major issue and slated to be fixed in version 1.3.6, it would most certainly seem to be a real code defect and not a misunderstanding.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37665 ]
George Jempty commented on STR-2903:
------------------------------------
you're absolutely right! it's amazing, I can recognize the elegance of my colleague's solution, to implement unspecified() such as to return our custom doWork(), but then I can be so fundamentally incorrect about such a comparatively simple matter. it's probably my scripting background getting in the way. anyway, it would make a good certification question: what gets printed based on the following source code. "live birth" of course. i will return to my cave now ;)
public class Animal {
public String exist() {
return giveBirth();
}
public String giveBirth() {
return "egg";
}
}
public class Mammal extends Animal {
public String exist() {
return super.exist();
}
public String giveBirth() {
return "live birth";
}
public static void main (String[] args) {
Mammal mammal = new Mammal();
System.out.println(mammal.exist());
}
}
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Hubert Rabago (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_38896 ]
Hubert Rabago commented on STR-2903:
------------------------------------
> I think we should override the getParameter() method - so that it doesn't throw an exception
+1
IMO that's how it should've worked from the beginning.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=all ]
George Jempty updated STR-2903:
-------------------------------
Attachment: MappingDispatchAction.patch.txt
Untested as of yet
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=all ]
Ted Husted updated STR-2903:
----------------------------
Fix Version: 1.x Next
(was: 1.3.5)
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Components: Extras
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Fix For: 1.x Next
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37664 ]
Niall Pemberton commented on STR-2903:
--------------------------------------
My mistake you're right it does use different keys - not sure what I was looking at - although its academic if it never gets called ;-)
I think you have a mis-understanding of java - if you override the getParameter() method it will get called - just because it calls the super classes execute() method doesn't mean that it then only uses the super classes getParameter() method - if you override it it will get used. Try it and see.
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=all ]
Niall Pemberton resolved STR-2903.
----------------------------------
Resolution: Fixed
Assignee: Niall Pemberton
Fix thanks!
http://svn.apache.org/viewvc?view=rev&revision=480570
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Issue Type: Bug
> Components: Extras
> Affects Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Assigned To: Niall Pemberton
> Fix For: 1.3.6
>
> Attachments: MappingDispatchAction.patch.txt
>
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (STR-2903) MappingDispatchAction throws an error
when mapping.getParameter returns null
Posted by "George Jempty (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/STR-2903?page=comments#action_37661 ]
George Jempty commented on STR-2903:
------------------------------------
Wendy: that would apply to DispatchAction: MappingDispatchAction does not rely on the request parameter, but rather the ActionMapping. If it's anywhere in documentation for MappingDispatchAction, I would guess it was cut and pasted from DispatchAction and not updated appropriately.
All:
If you can't tell I'm still in favor of adjusting the code, not the Javadoc ;) I was very excited when I read how MappingDispatchAction works because of the following. We already have an abstract action ("BaseCCAction") whose execute method in turn delegates to a custom abstract "doWork" method. BaseCCAction extends a BaseAction which extends Action. We thought we could have BaseAction instead extend MappingDispatchAction, and then a colleague of mine and Chuck's came up with the idea of simply having "unspecified()" delegate to our custom "doWork()". This was going to allow us to switch to MappingDispatchAction without having to change mappings: since our existing mappings do not specify a parameter attibute, they should invoke "unspecified" and then in turn "doWork".
Except that MappingDispatchAction, since it's execute invokes DispatchAction's execute, throws an error when there mapping.getParameter() returns null. Therefore I get an error instead of the expected call to unspecified.
In fact, as written, I don't believe unspecified() CAN EVER be relied upon to be called using MappingDispatchAction.
I know that Struts 1 is not the primary focus. I would however ask that before making a firm decision to NOT patch, you allow Chuck and I to work out our patch on our end?
TIA....George
> MappingDispatchAction throws an error when mapping.getParameter returns null
> ----------------------------------------------------------------------------
>
> Key: STR-2903
> URL: http://issues.apache.org/struts/browse/STR-2903
> Project: Struts 1
> Type: Bug
> Versions: 1.2.9
> Environment: Windows/Tomcat
> Reporter: George Jempty
> Attachments: MappingDispatchAction.patch.txt
>
> The JavaDoc for MappingDispatchAction states that unspecified() is the "method which is dispatched to when there is no value for the parameter in the ActionMapping." When I don't specify "parameter" in the ActionMapping however, I get the following stack trace:
> ERROR [http-8080-Processor24] (BaseCCAction.java:66) - DispatchMapping[/msalogin] does not define a handler property
> javax.servlet.ServletException: DispatchMapping[/msalogin] does not define a handler property
> at org.apache.struts.actions.DispatchAction.getParameter(DispatchAction.java:325)
> at org.apache.struts.actions.DispatchAction.execute(DispatchAction.java:170)
> at org.apache.struts.actions.MappingDispatchAction.execute(MappingDispatchAction.java:169)
> at com.cypresscare.web.common.actions.BaseCCAction.execute(BaseCCAction.java:60)
> at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
> My investigation shows that this is due to MappingDispatchAction's execute() method doing nothing except delegating to DispatchAction's execute() method:
> public ActionForward execute(
> ActionMapping mapping,
> ActionForm form,
> HttpServletRequest request,
> HttpServletResponse response)
> throws Exception {
>
> // Use the overridden getMethodName.
> return super.execute(mapping, form, request, response);
> }
> Furthermore, as evident from my attached stack trace, it is the overridden getParameter() that actually needs to be used
> HTH
> George Jempty (ps my manager is Chuck Cavaness!!)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira