You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/01/02 03:45:14 UTC
Review Request: Split apart the libprocess tests into separate test files.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8793/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This is part 2 of my refactoring to split apart the libprocess / stout tests.
This splits apart the libprocess tests into individual files.
There are no actual diffs to the *tests.cpp file contents, other than removed #includes on each one.
Diffs
-----
third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099
third_party/libprocess/src/tests/http_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/io_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/main.cpp PRE-CREATION
third_party/libprocess/src/tests/process_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/8793/diff/
Testing
-------
make check
cd third_party/libprocess
make check
Thanks,
Ben Mahler
Re: Review Request: Split apart the libprocess tests into separate test
files.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8793/#review15882
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Jan. 29, 2013, 1:52 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8793/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2013, 1:52 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is part 2 of my refactoring to split apart the libprocess / stout tests.
>
> This splits apart the libprocess tests into individual files.
> There are no actual diffs to the *tests.cpp file contents, other than removed #includes on each one.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099
> third_party/libprocess/src/tests/http_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/io_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/main.cpp PRE-CREATION
> third_party/libprocess/src/tests/process_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8793/diff/
>
>
> Testing
> -------
>
> make check
> cd third_party/libprocess
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Split apart the libprocess tests into separate test
files.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8793/
-----------------------------------------------------------
(Updated Jan. 29, 2013, 1:52 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
This is part 2 of my refactoring to split apart the libprocess / stout tests.
This splits apart the libprocess tests into individual files.
There are no actual diffs to the *tests.cpp file contents, other than removed #includes on each one.
Diffs (updated)
-----
third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099
third_party/libprocess/src/tests/http_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/io_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/main.cpp PRE-CREATION
third_party/libprocess/src/tests/process_tests.cpp PRE-CREATION
third_party/libprocess/src/tests/tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/8793/diff/
Testing
-------
make check
cd third_party/libprocess
make check
Thanks,
Ben Mahler
Re: Review Request: Split apart the libprocess tests into separate test
files.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8793/#review15034
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 2, 2013, 2:45 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8793/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2013, 2:45 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This is part 2 of my refactoring to split apart the libprocess / stout tests.
>
> This splits apart the libprocess tests into individual files.
> There are no actual diffs to the *tests.cpp file contents, other than removed #includes on each one.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099
> third_party/libprocess/src/tests/http_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/io_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/main.cpp PRE-CREATION
> third_party/libprocess/src/tests/process_tests.cpp PRE-CREATION
> third_party/libprocess/src/tests/tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/8793/diff/
>
>
> Testing
> -------
>
> make check
> cd third_party/libprocess
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>