You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/23 04:25:53 UTC

[GitHub] [pinot] sajjad-moradi commented on pull request #7780: Make split-commit the default segment commit protocol

sajjad-moradi commented on pull request #7780:
URL: https://github.com/apache/pinot/pull/7780#issuecomment-976159080


   > Why do we have this config on both controller and server?
   > 
   > Seems the controller one is for allowing split commit from servers. Should we consider removing this controller config? Controller should always allow splitting commit, unless there are some overhead enabling it
   > 
   > @mcvsubbu wdyt?
   
   That makes sense. Controller should properly handles calls from split committers as well as non-split committers. It's up to server configuration to enable/disable split commit.
   Maybe there's a legacy reason for it. Let's wait for @mcvsubbu to shed light on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org