You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Archie Cobbs (JIRA)" <ji...@apache.org> on 2010/11/19 22:13:25 UTC
[jira] Created: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Telnet client: Support Listener Notification of Incoming Data
-------------------------------------------------------------
Key: NET-344
URL: https://issues.apache.org/jira/browse/NET-344
Project: Commons Net
Issue Type: New Feature
Components: Telnet
Affects Versions: 2.0
Reporter: Archie Cobbs
I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Archie Cobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Archie Cobbs updated NET-344:
-----------------------------
Attachment: patch2.txt
Attaching patch to fix this issue.
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Archie Cobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Archie Cobbs updated NET-344:
-----------------------------
Attachment: NET-344_updated.txt
OK, {{NET-344_updated.txt}} contains just the remaining (uncommitted) part of the combined patch, i.e., it fixes just this issue.
Thanks,
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: NET-344_updated.txt, combined_NET-343_NET-344_NET-345_patch.txt, patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Archie Cobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934574#action_12934574 ]
Archie Cobbs commented on NET-344:
----------------------------------
FYI, the latest version of my combined patch to fix NET-343, NET-344, and NET-345 can be found [here|http://jvser.googlecode.com/svn/trunk/src/commons-net-telnet/patch.txt].
Please use this version as I'll be keeping it up to date.
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Archie Cobbs (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Archie Cobbs updated NET-344:
-----------------------------
Attachment: combined_NET-343_NET-344_NET-345_patch.txt
Attaching combined patch for NET-343, NET-344, NET-345.
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: combined_NET-343_NET-344_NET-345_patch.txt, patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved NET-344.
----------------------
Resolution: Fixed
Thanks, patch applied with minor modifications (e.g. removed @Override from TelnetInputStream.run() otherwise it does not compile with Java 1.5)
In future, please provide patches relative to the project root. Thanks.
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: NET-344_updated.txt, combined_NET-343_NET-344_NET-345_patch.txt, patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002034#comment-13002034 ]
Sebb commented on NET-344:
--------------------------
The other issues have been resolved.
Please attach a patch that fixes just the items necessary to complete this issue.
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Attachments: combined_NET-343_NET-344_NET-345_patch.txt, patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (NET-344) Telnet client: Support Listener
Notification of Incoming Data
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NET-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated NET-344:
---------------------
Fix Version/s: 3.0
> Telnet client: Support Listener Notification of Incoming Data
> -------------------------------------------------------------
>
> Key: NET-344
> URL: https://issues.apache.org/jira/browse/NET-344
> Project: Commons Net
> Issue Type: New Feature
> Components: Telnet
> Affects Versions: 2.0
> Reporter: Archie Cobbs
> Fix For: 3.0
>
> Attachments: NET-344_updated.txt, combined_NET-343_NET-344_NET-345_patch.txt, patch2.txt
>
>
> I am in the process of trying to implement a Java client for [RFC 2217|http://tools.ietf.org/html/rfc2217], which is the protocol for accessing serial ports over TCP. Unfortunately, the commons-net telnet client is insufficient for this relatively simple task.
> There are two missing features in the commons-net telnet client code, one of which is a show stopper (NET-343) and the other of which would be a "real nice to have". This issue documents the second problem:
> The API I am trying to support requires the ability to notify a listener that new incoming data is available. This would be trivial for me to do if only my library could somehow itself get a listener notification from the {{TelnetInputStream}} reader thread every time it reads new data. Unfortunately, there's no API provided for doing this, even though it would be trivial. So I have to implement a hack that requires a wrapper {{InputStream}} with yet another internal reader thread, etc. Bleh.
> I'm going to attempt to come up with a patch and will attach it here if successful.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira