[GitHub] [nuttx] acassis commented on a diff in pull request #8329: Ch32v: a pull request of commits to date

["acassis (via GitHub)" <gi...@apache.org>]

acassis commented on code in PR #8329:
URL: https://github.com/apache/nuttx/pull/8329#discussion_r1089791185


##########
boards/Kconfig:
##########
@@ -2668,6 +2675,7 @@ config ARCH_BOARD
 	default "axoloti"                  if ARCH_BOARD_AXOLOTI
 	default "bambino-200e"             if ARCH_BOARD_BAMBINO_200E
 	default "bl602evb"                 if ARCH_BOARD_BL602EVB
+	default "ch32v307evt"              if ARCH_BOARD_CH32V307EVT

Review Comment:
   @robertlipe please note that board names are sorted here, so please move it to below "c5471evm"



##########
arch/risc-v/include/ch32v/irq.h:
##########
@@ -0,0 +1,209 @@
+/****************************************************************************
+ * arch/risc-v/include/bl602/irq.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.  The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __ARCH_RISCV_INCLUDE_BL602_IRQ_H

Review Comment:
   Also replace all BL602 with CH32V



##########
arch/risc-v/include/ch32v/irq.h:
##########
@@ -0,0 +1,209 @@
+/****************************************************************************
+ * arch/risc-v/include/bl602/irq.h

Review Comment:
   Please fix the name replacing bl602 with ch32v



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org