You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/05/12 01:56:45 UTC
[jira] Created: (CASSANDRA-162) migrate to junit
migrate to junit
----------------
Key: CASSANDRA-162
URL: https://issues.apache.org/jira/browse/CASSANDRA-162
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708465#action_12708465 ]
Jonathan Ellis commented on CASSANDRA-162:
------------------------------------------
yeah, agreed about the speed.
I created CASSANDRA-163 for RackUnawareStrategyTest which is also unrelated to the move -- it wasn't getting run by testng b/c it was in the wrong directory before.
committed the basic migration.
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708388#action_12708388 ]
Johan Oskarsson commented on CASSANDRA-162:
-------------------------------------------
I won't have time to review the patch this week unfortunately, but +1 on moving to junit4
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708847#action_12708847 ]
Hudson commented on CASSANDRA-162:
----------------------------------
Integrated in Cassandra #73 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/73/])
extract tests that could conflict with each other to a separate test class (= gets own jvm)
patch by jbellis; reviewed by Sandeep Tata for
migrate to JUnit 4.6. patch by jbellis; reviewed by Sandeep Tata for
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708461#action_12708461 ]
Sandeep Tata commented on CASSANDRA-162:
----------------------------------------
BTW, the tests take approx 2x the time on my machine.
I think that's an acceptable price to pay for independent tests.
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708458#action_12708458 ]
Sandeep Tata commented on CASSANDRA-162:
----------------------------------------
I get failures for namesort, timesort, testcompaction. I'm getting these even on a clean checkout of trunk -- so this is unrelated to the move to junit.
RackUnawareStrategyTest fails with no runnable methods. (Everything in it seems to be commented out).
I'm +1 after fixing RackUnawareStrategyTest (taking a quick look at the code, the other failures seem unrelated to the junit move).
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-162) migrate to junit
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708284#action_12708284 ]
Jonathan Ellis commented on CASSANDRA-162:
------------------------------------------
you'll want to put the junit4 jar in lib/ to run the tests w/ this applied.
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-162) migrate to junit
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708284#action_12708284 ]
Jonathan Ellis edited comment on CASSANDRA-162 at 5/11/09 6:18 PM:
-------------------------------------------------------------------
you'll want to put the junit4 jar in lib/ to run the tests w/ this applied. (I'm using 4.6.)
was (Author: jbellis):
you'll want to put the junit4 jar in lib/ to run the tests w/ this applied.
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-162) migrate to junit
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-162:
-------------------------------------
Attachment: 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-162) migrate to junit
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-162.
--------------------------------------
Resolution: Fixed
> migrate to junit
> ----------------
>
> Key: CASSANDRA-162
> URL: https://issues.apache.org/jira/browse/CASSANDRA-162
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-162-migrate-to-JUnit-4.6.txt, 0002-extract-tests-that-could-conflict-with-each-other-to-a.txt
>
>
> junit has a fork option which will allow our tests to be 100% independent of each other instead of sorta kinda independent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.