You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by rohanjulka19 <gi...@git.apache.org> on 2018/03/12 11:21:41 UTC
[GitHub] syncope pull request #68: Fixing the netbeans plugin
GitHub user rohanjulka19 opened a pull request:
https://github.com/apache/syncope/pull/68
Fixing the netbeans plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rohanjulka19/syncope master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 6b489f7cd27df0b46d38533c70e8bb0b9e92f538
Author: rohanjulka19 <ro...@...>
Date: 2018-03-12T11:15:22Z
Fixing the netbeans plugin
----
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/syncope/pull/68
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r173764200
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
<build>
<plugins>
- <plugin>
+ <plugin>
--- End diff --
Please do not change indentation.
---
[GitHub] syncope issue #68: Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
Please add the text `[SYNCOPE-1220]` to your commit's message, to link this PR's commits to JIRA, thanks.
---
[GitHub] syncope issue #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
Thanks for your contribution @rohanjulka19 !
Sorry it took so long: as you can see, I've squashed your commits before merging.
Moreover, I've merged the commit to both `master` and `2_0_X` branches (the icon was missing in both places as it seems).
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174040731
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
<build>
<plugins>
- <plugin>
+ <plugin>
--- End diff --
No need to open a new PR, just revert this sole change and make a new commit: it will be added to this PR.
Once the review is finished, you might be asked to squash all the commits, but for the moment it will work like this.
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by rohanjulka19 <gi...@git.apache.org>.
Github user rohanjulka19 commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174040384
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
<build>
<plugins>
- <plugin>
+ <plugin>
--- End diff --
yes ok I won't sorry for causing the trouble should I fix it and open the pr again .
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174045249
--- Diff: ide/netbeans/pom.xml ---
@@ -133,7 +133,6 @@ under the License.
<useOSGiDependencies>false</useOSGiDependencies>
</configuration>
</plugin>
-
--- End diff --
Any reason to remove this line?
---
[GitHub] syncope issue #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the issue:
https://github.com/apache/syncope/pull/68
> It seems that not much people use netbeans plugin
Agree, but after SYNCOPE-1220 there should be much many reasons to do that ;-)
Are you still interested in GSoC? Why don't you submit an official proposal on SYNCOPE-1220?
---
[GitHub] syncope issue #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by rohanjulka19 <gi...@git.apache.org>.
Github user rohanjulka19 commented on the issue:
https://github.com/apache/syncope/pull/68
Thank you for acknowledging this issue and helping me out . It seems that not much people use netbeans plugin. But beside that I hope to contribute more and more to apache syncope.
---
[GitHub] syncope issue #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by rohanjulka19 <gi...@git.apache.org>.
Github user rohanjulka19 commented on the issue:
https://github.com/apache/syncope/pull/68
I am interested in Gsoc 2018 but I have an exam on 18th march so I was thinking of submitting it after 18th as it will require time . I will submit the proposal latest by 19th and it will be helpful if I get your review on it .
---
[GitHub] syncope pull request #68: SYNCOPE-1220 Fixing the netbeans plugin
Posted by rohanjulka19 <gi...@git.apache.org>.
Github user rohanjulka19 commented on a diff in the pull request:
https://github.com/apache/syncope/pull/68#discussion_r174041172
--- Diff: ide/netbeans/pom.xml ---
@@ -124,7 +124,7 @@ under the License.
<build>
<plugins>
- <plugin>
+ <plugin>
--- End diff --
ok
---