You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fangyincheng (GitHub)" <gi...@apache.org> on 2019/09/24 14:45:06 UTC

[GitHub] [dubbo-go] fangyincheng opened pull request #214: Ftr: AccessLogFilter support

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:
Add AccessLogFilter

**Which issue(s) this PR fixes**:
[Ftr: AccessLogFilter support](https://github.com/apache/dubbo-go/issues/211)

<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:
Please review the code about channel and file operation carefully. I'm new to Golang.

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `61.6%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    66.11%   65.94%   -0.18%     
===========================================
  Files           96       97       +1     
  Lines         6455     6565     +110     
===========================================
+ Hits          4268     4329      +61     
- Misses        1743     1789      +46     
- Partials       444      447       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.88% <100%> (+0.85%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `59.43% <59.43%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dcbd967...631a024](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on pull request #214: Ftr: AccessLogFilter support

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
Why warnf? `logger.Infof("[AccessLogFilter] %s", invoker.GetUrl().Key())` will is better.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #214: Ftr: AccessLogFilter support

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
this check is so ugly. u can handle the first case specially. And then use `for idx := 1; idx < len(invocation.Arguments(); idx++{` 

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.22%   +0.06%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4247      +77     
- Misses        1792     1826      +34     
- Partials       437      438       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...568e015](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.22%   +0.06%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4247      +77     
- Misses        1792     1827      +35     
  Partials       437      437
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.29% <71.29%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...9c4ae4e](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #214: Ftr: AccessLogFilter support

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.22%   +0.06%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4247      +77     
- Misses        1792     1826      +34     
- Partials       437      438       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...25c3bf9](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on issue #214: Ftr: AccessLogFilter support

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
@fangyincheng u recheck it and merge it, pls.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #214: Ftr: AccessLogFilter support

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
> @fangyincheng should the examples be placed in [dubbogo-examples](https://github.com/dubbogo/dubbogo-samples)?

yes

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.22%   +0.06%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4247      +77     
- Misses        1792     1826      +34     
- Partials       437      438       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...8600f70](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.21%   +0.04%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4246      +76     
- Misses        1792     1828      +36     
  Partials       437      437
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `61.3% <0%> (+1.5%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...17d2a8c](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #214: Ftr: AccessLogFilter support

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
> I change the example to be comments:
> ![image](https://user-images.githubusercontent.com/9923838/65509638-7ad32800-df05-11e9-9a5a-773167d0b357.png)
> 
> It would be better.

Should it be default or user configuration? What about Java dubbo? And should you add some comments in `access_log_filter.go` instead of examples?

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `61.6%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    66.11%   65.97%   -0.15%     
===========================================
  Files           96       97       +1     
  Lines         6455     6565     +110     
===========================================
+ Hits          4268     4331      +63     
- Misses        1743     1787      +44     
- Partials       444      447       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.88% <100%> (+0.85%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `59.43% <59.43%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dcbd967...6657456](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.22%   +0.06%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4247      +77     
- Misses        1792     1826      +34     
- Partials       437      438       +1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...7d01558](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dfbdd01757830ff1597e9d321331a50cbf1b630d?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `72.8%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
+ Coverage    65.16%   65.25%   +0.09%     
===========================================
  Files           94       95       +1     
  Lines         6399     6511     +112     
===========================================
+ Hits          4170     4249      +79     
- Misses        1792     1825      +33     
  Partials       437      437
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `65.51% <100%> (+0.4%)` | :arrow_up: |
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `51.19% <100%> (+1.19%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `71.02% <71.02%> (ø)` | |
| [filter/impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvaHlzdHJpeF9maWx0ZXIuZ28=) | `68.64% <0%> (-3.39%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `61.3% <0%> (+1.5%)` | :arrow_up: |
| [config\_center/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci96b29rZWVwZXIvbGlzdGVuZXIuZ28=) | `86.95% <0%> (+4.34%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dfbdd01...17d2a8c](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #214: Ftr: AccessLogFilter support

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
in dubbo accessLogKey is dubbo.accesslog.
I recommand to change the key.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #214: Ftr: AccessLogFilter support

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
> It's a default filter in Java. But if the user does not specify the value of "accesslog" to store the access log. It won't do anything.
> So, maybe we could make it as default filter. But if the user doesn't configure the of "accesslog", we do nothing.

you are right. Pls do it.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on issue #214: Ftr: AccessLogFilter support

Posted by "flycash (GitHub)" <gi...@apache.org>.
I change the example to be comments:
![image](https://user-images.githubusercontent.com/9923838/65509638-7ad32800-df05-11e9-9a5a-773167d0b357.png)

It would be better.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] fangyincheng commented on issue #214: Ftr: AccessLogFilter support

Posted by "fangyincheng (GitHub)" <gi...@apache.org>.
How to start this filter？

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.08%`.
> The diff coverage is `62.06%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    66.11%   66.03%   -0.09%     
===========================================
  Files           96       97       +1     
  Lines         6455     6569     +114     
===========================================
+ Hits          4268     4338      +70     
- Misses        1743     1783      +40     
- Partials       444      448       +4
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.88% <100%> (+0.85%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `60% <60%> (ø)` | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dcbd967...c5082fd](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.17%`.
> The diff coverage is `61.6%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    66.11%   65.94%   -0.18%     
===========================================
  Files           96       97       +1     
  Lines         6455     6565     +110     
===========================================
+ Hits          4268     4329      +61     
- Misses        1743     1789      +46     
- Partials       444      447       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.88% <100%> (+0.85%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `59.43% <59.43%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `50.5% <0%> (-1.02%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dcbd967...241e692](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #214: Ftr: AccessLogFilter support

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls give the init len for this dataMap. 16 may be good.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #214: Ftr: AccessLogFilter support

Posted by "hxmhlt (GitHub)" <gi...@apache.org>.
import format

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on issue #214: Ftr: AccessLogFilter support

Posted by "flycash (GitHub)" <gi...@apache.org>.
done, pls review that

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #214: Ftr: AccessLogFilter support

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/dcbd9679cef41c0b6426b46fb4553193ffa3842c?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `61.6%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/214/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #214      +/-   ##
===========================================
- Coverage    66.11%   65.97%   -0.15%     
===========================================
  Files           96       97       +1     
  Lines         6455     6565     +110     
===========================================
+ Hits          4268     4331      +63     
- Misses        1743     1787      +44     
- Partials       444      447       +3
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `64.88% <100%> (+0.85%)` | :arrow_up: |
| [filter/impl/access\_log\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-ZmlsdGVyL2ltcGwvYWNjZXNzX2xvZ19maWx0ZXIuZ28=) | `59.43% <59.43%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (-1.04%)` | :arrow_down: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/214/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.87% <0%> (-0.58%)` | :arrow_down: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=footer). Last update [dcbd967...241e692](https://codecov.io/gh/apache/dubbo-go/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on pull request #214: Ftr: AccessLogFilter support

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
pls see other go files. split this import block into 3 blocks.

[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on pull request #214: Ftr: AccessLogFilter support

Posted by "flycash (GitHub)" <gi...@apache.org>.
It's the ACCESS_LOG_KEY, not the LOG_KEY. The difference is that the LOG_KEY is used to fetch the Logger. But the ACCESS_LOG_KEY is used to fetch the AccessLogFilter configuration from URL.
The code in Java is:
![image](https://user-images.githubusercontent.com/9923838/65419785-04192a80-de32-11e9-9323-4728a5107978.png)

![image](https://user-images.githubusercontent.com/9923838/65419838-21e68f80-de32-11e9-8c05-a26187d89d06.png)

we don't have the similar mechanism to fetch different logger. So I only need to define the ACCESS_LOG_KEY.

![image](https://user-images.githubusercontent.com/9923838/65419805-0da29280-de32-11e9-8bf6-a5b7e4108cdc.png)

![image](https://user-images.githubusercontent.com/9923838/65419820-198e5480-de32-11e9-97de-f438352342ee.png)


[ Full content available at: https://github.com/apache/dubbo-go/pull/214 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org