[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

[GitBox <gi...@apache.org>]

darenwkt commented on code in PR #39:
URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1051106792


##########
flink-connector-aws-base/pom.xml:
##########
@@ -52,6 +52,11 @@ under the License.
             <artifactId>netty-nio-client</artifactId>
         </dependency>
 
+        <dependency>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>apache-client</artifactId>
+        </dependency>

Review Comment:
   Verified that apache-client is in the installed JAR.
   
   <img width="461" alt="Screenshot 2022-12-16 at 19 51 45" src="https://user-images.githubusercontent.com/108749182/208178095-b0490c6f-67c7-4b59-90e2-811415ad2004.png">
   
   
   Verified that NOTICE files are updated.
   
   ```
   
   - software.amazon.awssdk:apache-client:2.17.247
   - software.amazon.awssdk:netty-nio-client:2.17.247
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org