[GitHub] [iceberg] rdblue commented on a diff in pull request #6323: Python: Alter table plumbing and REST support

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6323:
URL: https://github.com/apache/iceberg/pull/6323#discussion_r1217003884


##########
python/pyiceberg/table/__init__.py:
##########
@@ -69,21 +72,288 @@
     import ray
     from duckdb import DuckDBPyConnection
 
+    from pyiceberg.catalog import Catalog
 
 ALWAYS_TRUE = AlwaysTrue()
 
 
+class TableUpdates:

Review Comment:
   > Would it be possible to add more tests later once we get the schema, partitioning, and sorting figured out?
   
   Yes! I think we should limit this to setting and removing properties. Then we can handle the schema, spec, and write order changes later.
   
   > However, this gets awkward for lists, maps, and structs.
   
   We already handle these cases in the Java API, using the same approach that you outlined above with methods to make individual changes to the schema that correspond to SQL DDL operations (e.g. ADD COLUMN). There are [thorough tests](https://github.com/apache/iceberg/blob/master/core/src/test/java/org/apache/iceberg/TestSchemaUpdate.java#L669-L737) as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org