[jira] [Commented] (ARROW-12626) [C++] Build doesn't find external xsimd, and then installs a bundled one into a wrong path

["Wes McKinney (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542638#comment-17542638 ] 

Wes McKinney commented on ARROW-12626:
--------------------------------------

[~assignUser] the C++ build system does not support system / toolchain xsimd at all, which you can see in this code:

{code}
if(ARROW_USE_XSIMD)
  set(xsimd_SOURCE "BUNDLED")
  resolve_dependency(xsimd)

  add_library(xsimd INTERFACE IMPORTED)
  if(CMAKE_VERSION VERSION_LESS 3.11)
    set_target_properties(xsimd PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
                                           "${XSIMD_INCLUDE_DIR}")
  else()
    target_include_directories(xsimd INTERFACE "${XSIMD_INCLUDE_DIR}")
  endif()
endif()
{code}

It would be good to support the user's toolchain xsimd (for example: installed by conda) if it is new enough

> [C++] Build doesn't find external xsimd, and then installs a bundled one into a wrong path
> ------------------------------------------------------------------------------------------
>
>                 Key: ARROW-12626
>                 URL: https://issues.apache.org/jira/browse/ARROW-12626
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 4.0.0
>            Reporter: Yuri
>            Priority: Major
>
> cmake script accept -Dxsimd_SOURCE=SYSTEM but then it prints:
> {code:java}
> -- ARROW_XSIMD_BUILD_VERSION: e9234cd6e6f4428fc260073b2c34ffe86fda1f34
> ...
> -- Building xsimd from source
> {code}
> Then it installs files with build directory paths:
> {code:java}
> ===> Checking for items in STAGEDIR missing from pkg-plist
> Error: Orphaned: /usr/ports/databases/arrow/work/.build/xsimd_ep/src/xsimd_ep-install/include/xsimd/config/xsimd_align.hpp
> Error: Orphaned: /usr/ports/databases/arrow/work/.build/xsimd_ep/src/xsimd_ep-install/include/xsimd/config/xsimd_config.hpp
> Error: Orphaned: /usr/ports/databases/arrow/work/.build/xsimd_ep/src/xsimd_ep-install/include/xsimd/config/xsimd_include.hpp
> Error: Orphaned: /usr/ports/databases/arrow/work/.build/xsimd_ep/src/xsimd_ep-install/include/xsimd/config/xsimd_instruction_set.hpp
> Error: Orphaned: /usr/ports/databases/arrow/work/.build/xsimd_ep/src/xsimd_ep-install/include/xsimd/math/xsimd_basic_math.hpp
> {code}
> OS: FreeBSD 12.2
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.7#820007)