[GitHub] [avro] tjwp opened a new pull request #1190: AVRO-3112: Freeze string literals for Ruby

[GitBox <gi...@apache.org>]

tjwp opened a new pull request #1190:
URL: https://github.com/apache/avro/pull/1190


   https://issues.apache.org/jira/browse/AVRO-3112
   
   Freeze all string literals in Ruby by default to improve performance and ensure reliability.
   
   This is implemented by adding the `frozen_string_literal: true` pragma to all ruby files. This comment was added using the RuboCop linting and style checking tool already present. To support this, a RuboCop configuration was added to enforce this rule and a couple of related (redundant string freezes and mutable constants) in addition to the lint rules that were checked previously.
   
   Manual code changes were needed in a couple of places where strings needed to be mutable or constants are mutated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] tjwp merged pull request #1190: AVRO-3112: Freeze string literals for Ruby

[GitBox <gi...@apache.org>]

tjwp merged pull request #1190:
URL: https://github.com/apache/avro/pull/1190


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org