[GitHub] [spark] grundprinzip commented on a diff in pull request #37075: [SparkConnect] Initial Protobuf Definitions

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #37075:
URL: https://github.com/apache/spark/pull/37075#discussion_r913806860


##########
sql/core/pom.xml:
##########
@@ -145,6 +145,30 @@
       <groupId>org.apache.xbean</groupId>
       <artifactId>xbean-asm9-shaded</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.grpc</groupId>
+      <artifactId>grpc-netty-shaded</artifactId>
+      <scope>runtime</scope>
+    </dependency>
+    <dependency>
+      <groupId>io.grpc</groupId>
+      <artifactId>grpc-protobuf</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>io.grpc</groupId>
+      <artifactId>grpc-stub</artifactId>
+    </dependency>
+    <dependency> <!-- necessary for Java 9+ -->
+      <groupId>org.apache.tomcat</groupId>
+      <artifactId>annotations-api</artifactId>
+      <scope>provided</scope>
+    </dependency>
+    <!-- TODO(grundprinzip) fix the scala pb version -->
+    <dependency>
+      <groupId>com.thesamet.scalapb</groupId>
+      <artifactId>scalapb-runtime-grpc_2.12</artifactId>

Review Comment:
   Thanks, fixed it.



##########
sql/core/pom.xml:
##########
@@ -265,6 +297,36 @@
           </execution>
         </executions>
       </plugin>
+      <!-- Add protobuf-maven-plugin and provide ScalaPB as a code generation plugin -->

Review Comment:
   Yeah, I had to find a colleague with M1 to test, I pushed a new version that actually works.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org