You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rajith Attapattu (Created) (JIRA)" <ji...@apache.org> on 2012/03/06 04:10:27 UTC

[jira] [Created] (QPID-3886) Improve knownComplete processing in the java client

Improve knownComplete processing in the java client
---------------------------------------------------

                 Key: QPID-3886
                 URL: https://issues.apache.org/jira/browse/QPID-3886
             Project: Qpid
          Issue Type: Improvement
          Components: Java Client
    Affects Versions: 0.14
            Reporter: Rajith Attapattu
            Assignee: Rajith Attapattu
             Fix For: Future


Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3886) Improve knownComplete processing in the java client

Posted by "Kevin Conner (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Conner updated QPID-3886:
-------------------------------

    Attachment: known-complete.patch
    
> Improve knownComplete processing in the java client
> ---------------------------------------------------
>
>                 Key: QPID-3886
>                 URL: https://issues.apache.org/jira/browse/QPID-3886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: Future
>
>         Attachments: known-complete.patch
>
>
> Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3886) Improve knownComplete processing in the java client

Posted by "Rajith Attapattu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223372#comment-13223372 ] 

Rajith Attapattu commented on QPID-3886:
----------------------------------------

Thanks Rob for having a look, I will ask Kevin to attach the patches himself.

Regards,

Rajith
                
> Improve knownComplete processing in the java client
> ---------------------------------------------------
>
>                 Key: QPID-3886
>                 URL: https://issues.apache.org/jira/browse/QPID-3886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: Future
>
>
> Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-3886) Improve knownComplete processing in the java client

Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rajith Attapattu resolved QPID-3886.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Future)
                   0.16

Patch applied to trunk
                
> Improve knownComplete processing in the java client
> ---------------------------------------------------
>
>                 Key: QPID-3886
>                 URL: https://issues.apache.org/jira/browse/QPID-3886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: 0.16
>
>         Attachments: known-complete.patch
>
>
> Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3886) Improve knownComplete processing in the java client

Posted by "Rob Godfrey (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223289#comment-13223289 ] 

Rob Godfrey commented on QPID-3886:
-----------------------------------

The patch looks reasonable to me, though if the patch is from Kevin and not yourself I think we at least need some sort of acknowledgment from him around the licensing (though I know he works in the same organization as you, I think there needs to be at least some statement that you have the right to commit this code under the Apache license).
                
> Improve knownComplete processing in the java client
> ---------------------------------------------------
>
>                 Key: QPID-3886
>                 URL: https://issues.apache.org/jira/browse/QPID-3886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: Future
>
>
> Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-3886) Improve knownComplete processing in the java client

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222964#comment-13222964 ] 

jiraposter@reviews.apache.org commented on QPID-3886:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4189/
-----------------------------------------------------------

Review request for qpid and Robbie Gemmell.


Summary
-------

Patch provided by Kevin Conner


This addresses bug QPID-3886.
    https://issues.apache.org/jira/browse/QPID-3886


Diffs
-----

  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Range.java 1297330 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/RangeSet.java 1297330 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/RangeSetImpl.java 1297330 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Session.java 1297330 
  http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/test/java/org/apache/qpid/transport/RangeSetTest.java 1297330 

Diff: https://reviews.apache.org/r/4189/diff


Testing
-------

Contains test cases.


Thanks,

rajith


                
> Improve knownComplete processing in the java client
> ---------------------------------------------------
>
>                 Key: QPID-3886
>                 URL: https://issues.apache.org/jira/browse/QPID-3886
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Client
>    Affects Versions: 0.14
>            Reporter: Rajith Attapattu
>            Assignee: Rajith Attapattu
>             Fix For: Future
>
>
> Attaching a patch by Kevin Conner for review/discussion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org