You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/09 09:04:39 UTC
[GitHub] [incubator-doris] wangshuo128 commented on a diff in pull request #9470: [refactor](Nereids): small refactor
wangshuo128 commented on code in PR #9470:
URL: https://github.com/apache/incubator-doris/pull/9470#discussion_r867792476
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -21,19 +21,21 @@
import org.apache.doris.nereids.trees.plans.logical.LogicalPlan;
import com.google.common.collect.Lists;
+import org.glassfish.jersey.internal.guava.Sets;
+import java.util.HashSet;
import java.util.List;
/**
* Representation for memo in cascades optimizer.
*/
public class Memo {
private final List<Group> groups = Lists.newArrayList();
- private final List<PlanReference> planReferences = Lists.newArrayList();
+ private final HashSet<GroupExpression> groupExpressions = Sets.newHashSet();
Review Comment:
```suggestion
private final Set<GroupExpression> groupExpressions = Sets.newHashSet();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org