[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15463: [Improvement](decimalv3) Add a config to check overflow for DECIMALV3

[GitBox <gi...@apache.org>]

github-actions[bot] commented on code in PR #15463:
URL: https://github.com/apache/doris/pull/15463#discussion_r1058710819


##########
be/src/vec/data_types/data_type_decimal.h:
##########
@@ -71,6 +71,11 @@ constexpr Int128 max_decimal_value<Decimal128>() {
     return static_cast<int128_t>(999999999999999999ll) * 100000000000000000ll * 1000ll +
            static_cast<int128_t>(99999999999999999ll) * 1000ll + 999ll;
 }
+template <>
+constexpr Int128 max_decimal_value<Decimal128I>() {

Review Comment:
   warning: unused function 'max_decimal_value<doris::vectorized::Decimal<doris::vectorized::Int128I>>' [clang-diagnostic-unused-function]
   ```cpp
   constexpr Int128 max_decimal_value<Decimal128I>() {
                    ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org