You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Alejandro Abdelnur (Created) (JIRA)" <ji...@apache.org> on 2011/12/08 23:03:39 UTC
[jira] [Created] (HADOOP-7899) Generate proto java files as part of
the build
Generate proto java files as part of the build
----------------------------------------------
Key: HADOOP-7899
URL: https://issues.apache.org/jira/browse/HADOOP-7899
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 0.24.0, 0.23.1
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Fix For: 0.24.0, 0.23.1
currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166602#comment-13166602 ]
Suresh Srinivas commented on HADOOP-7899:
-----------------------------------------
This will go in along with the related protobuf changes. However it does require lot of testing. Will port it along with other patches.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166583#comment-13166583 ]
Alejandro Abdelnur commented on HADOOP-7899:
--------------------------------------------
Suresh, apologies, I've missed your comment before.
The -1 from jenkins do not apply, this patch does not introduce/modify any java code, actually it deletes autogenerated java code and generate/compiles those files as part of the build.
Regarding your last comment that this has not gone in 0.23 yet. Will it go into 0.23? If so, when that happens we have to do this patch there.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166614#comment-13166614 ]
Hudson commented on HADOOP-7899:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1415 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1415/])
HADOOP-7899. Generate proto java files as part of the build. (tucu)
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212615
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/package-info.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166554#comment-13166554 ]
Suresh Srinivas commented on HADOOP-7899:
-----------------------------------------
Alejandro, please respond to -1s from Jenkins before committing the patch.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166557#comment-13166557 ]
Alejandro Abdelnur commented on HADOOP-7899:
--------------------------------------------
committed to trunk, but don't see the proto files in branch-0.23, seems that the patch that introduced it has not been backported.
Leaving this JIRA open til get some clarification on what to do in branch-0.23
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Ravi Teja Ch N V (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168174#comment-13168174 ]
Ravi Teja Ch N V commented on HADOOP-7899:
------------------------------------------
Hi Alejandro,
As Uma has mentioned,it works on Linux env, but its broken in windows env. Can you please look into the issue as its kinda blocking as we unable to build the jars.
Thanks :)
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168366#comment-13168366 ]
Alejandro Abdelnur commented on HADOOP-7899:
--------------------------------------------
Ravi, Uma,
I don't have a WIN environment, I have to setup a VM. I'll try do this TUE. In the mean time, if you can try to make the script cygwin friendly it would be great.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167484#comment-13167484 ]
Uma Maheswara Rao G commented on HADOOP-7899:
---------------------------------------------
Hi Alejandro,
Looks build is failing for the windows dev environments.
[ERROR] \Trunk-Common\hadoop-common-project\hadoop-common\src\main\java\org\apac
he\hadoop\ipc\ProtobufRpcEngine.java:[425,8] cannot find symbol
symbol : class HadoopRpcResponseProto
location: class org.apache.hadoop.ipc.ProtobufRpcEngine.Server.ProtoBufRpcInvoke
r
[INFO] 29 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Hadoop Main ................................ SUCCESS [1.971s]
[INFO] Apache Hadoop Project POM ......................... SUCCESS [0.641s]
[INFO] Apache Hadoop Annotations ......................... SUCCESS [1.862s]
[INFO] Apache Hadoop Project Dist POM .................... SUCCESS [0.469s]
[INFO] Apache Hadoop Assemblies .......................... SUCCESS [0.250s]
[INFO] Apache Hadoop Auth ................................ SUCCESS [3.176s]
[INFO] Apache Hadoop Auth Examples ....................... SUCCESS [2.018s]
[INFO] Apache Hadoop Common .............................. FAILURE [11.404s]
[INFO] Apache Hadoop Common Project ...................... SKIPPED
[INFO] Apache Hadoop HDFS ................................ SKIPPED
[INFO] Apache Hadoop HttpFS .............................. SKIPPED
I think it is working fine for the Linux environments.
Since yours is a familiar hand here, could you please take a look?
Am i missing something here?
Thanks
Uma
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168493#comment-13168493 ]
Alejandro Abdelnur commented on HADOOP-7899:
--------------------------------------------
Patch avail at HADOOP-7917
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166900#comment-13166900 ]
Hudson commented on HADOOP-7899:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #923 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/923/])
HADOOP-7899. Generate proto java files as part of the build. (tucu)
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212615
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/package-info.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Tom White (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166500#comment-13166500 ]
Tom White commented on HADOOP-7899:
-----------------------------------
+1
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166562#comment-13166562 ]
Hudson commented on HADOOP-7899:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1467 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1467/])
HADOOP-7899. Generate proto java files as part of the build. (tucu)
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212615
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/package-info.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7899) Generate proto java files as part of
the build
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-7899:
---------------------------------------
Status: Patch Available (was: Open)
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7899) Generate proto java files as part of
the build
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7899:
-------------------------------------------
Affects Version/s: (was: 0.23.1)
Fix Version/s: (was: 0.23.1)
0.23.3
I have merged this to 0.23.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166888#comment-13166888 ]
Hudson commented on HADOOP-7899:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #890 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/890/])
HADOOP-7899. Generate proto java files as part of the build. (tucu)
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212615
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/package-info.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7899) Generate proto java files as part of
the build
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7899:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This was committed some time ago. Resolving.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219382#comment-13219382 ]
Suresh Srinivas commented on HADOOP-7899:
-----------------------------------------
When proto files cannot be compiled, the build still continues. Filing a bug a for that.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166573#comment-13166573 ]
Suresh Srinivas commented on HADOOP-7899:
-----------------------------------------
This is not gone into 0.23 yet. Can you please comment on my previous comment?
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Alejandro Abdelnur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166492#comment-13166492 ]
Alejandro Abdelnur commented on HADOOP-7899:
--------------------------------------------
tested by doing clean build, including testcases.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168525#comment-13168525 ]
Uma Maheswara Rao G commented on HADOOP-7899:
---------------------------------------------
Thanks a lot, Alejandro for the patch, I will verify it on HADOOP-7917.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166517#comment-13166517 ]
Hadoop QA commented on HADOOP-7899:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506670/HADOOP-7899v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed the unit tests build
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/458//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/458//console
This message is automatically generated.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7899) Generate proto java files as part
of the build
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166549#comment-13166549 ]
Hudson commented on HADOOP-7899:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1393 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1393/])
HADOOP-7899. Generate proto java files as part of the build. (tucu)
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212615
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/package-info.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7899) Generate proto java files as part of
the build
Posted by "Alejandro Abdelnur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-7899:
---------------------------------------
Attachment: HADOOP-7899v1.patch
HADOOP-7899v1.sh
Run script from src root then apply patch.
The script requires one parameter fs|svn (fs for GIT, svn for SVN).
The script deletes the generated JAVA files and moves src/proto to src/main/proto
The generated files are found by IDEs as they are in target/generated-sources/java.
> Generate proto java files as part of the build
> ----------------------------------------------
>
> Key: HADOOP-7899
> URL: https://issues.apache.org/jira/browse/HADOOP-7899
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.24.0, 0.23.1
>
> Attachments: HADOOP-7899v1.patch, HADOOP-7899v1.sh
>
>
> currently the generated java files are precompiled and checked in into the source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira