You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/08/13 09:11:50 UTC
[PR] fix: validate instance name on creation [rocketmq-dashboard]
btlqql opened a new pull request, #2100:
URL: https://github.com/apache/rocketmq-dashboard/pull/2100
## What is the purpose of the change
Fix #2075.
CreateInstanceDTO had no validation annotations, unlike sibling DTOs, so invalid payloads reached the service layer.
## Brief changelog
- CreateInstanceDTO: add @NotBlank on name
## How was this patch verified
- InstanceController already applies @Valid; cloud create path unaffected (endpoint/type/vendor stay optional)
- git diff --check clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: validate instance name on creation [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2100: fix: validate instance name on creation
URL: https://github.com/apache/rocketmq-dashboard/pull/2100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: validate instance name on creation [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2100:
URL: https://github.com/apache/rocketmq-dashboard/pull/2100#issuecomment-5291348768
Closing per contribution guideline #2107: these are fragmented one-off changes of the same theme (one PR per guard/fix/page). Please group related changes into cohesive pull requests and resubmit — your contributions are welcome in a consolidated shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org