You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2024/12/20 18:18:45 UTC

[PR] Test parent 79 [commons-validator]

slawekjaranowski opened a new pull request, #298:
URL: https://github.com/apache/commons-validator/pull/298

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Bump org.apache.commons:commons-parent from 78 to 79, fix changes.xml format for new plugin version [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #298:
URL: https://github.com/apache/commons-validator/pull/298#issuecomment-2565231523

   @sebbASF @garydgregory updated ... should be ok after parent 79 will be released


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #298:
URL: https://github.com/apache/commons-validator/pull/298#issuecomment-2564558248

   @sebbASF 
   All these changes must be done at once, @slawekjaranowski and I are working to get Doxia 2 from the commons-skin to the commons-parent down to components. This PR can be reopened as a draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #298:
URL: https://github.com/apache/commons-validator/pull/298#discussion_r1894290845


##########
src/changes/changes.xml:
##########
@@ -1041,284 +1035,5 @@ http://commons.apache.org/validator/dependencies.html
     Fixed javascript email domain length limited to 2 or 3 chars.
     </action>
   </release>
-
-  <release version="1.1.2 (alpha)" date="2004-04-03" description="1.1 Alpha">
-    <action dev="rleland" type="fix" issue="VALIDATOR-24">

Review Comment:
   removed only for testing purpose - to fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #298:
URL: https://github.com/apache/commons-validator/pull/298#discussion_r1894290290


##########
src/changes/changes.xml:
##########
@@ -873,19 +871,15 @@ http://commons.apache.org/validator/dependencies.html
      Resolve issue in JavaScript validation when the prototype library
      is used.
     </action>
-    <action dev="niallp" type="fix">
+    <action dev="niallp" type="fix" fixedIssues="VALIDATOR-97, VALIDATOR-81" due-to="Matt Bathje, Paul Benedict">

Review Comment:
   😄 there is a bug in m-changes-p arrtibute name should be `fixed-issues`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #298:
URL: https://github.com/apache/commons-validator/pull/298#discussion_r1894286362


##########
src/changes/changes.xml:
##########
@@ -779,8 +779,8 @@ http://commons.apache.org/validator/dependencies.html
     </action>
     <action dev="niallp" type="fix" issue="VALIDATOR-190">
     EmailValidator allows control characters (ASCII 0-31 and 127).
-    <dueto name="Cott"/>
-    <dueto name="Gabriel Belingueres"/>
+<!--    <dueto name="Cott"/>-->
+<!--    <dueto name="Gabriel Belingueres"/>-->

Review Comment:
   dueto to attribute



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Bump org.apache.commons:commons-parent from 78 to 79, fix changes.xml format for new plugin version [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #298:
URL: https://github.com/apache/commons-validator/pull/298#issuecomment-2578769559

   @garydgregory @sebbASF it is ready 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #298:
URL: https://github.com/apache/commons-validator/pull/298#discussion_r1894287175


##########
src/changes/changes.xml:
##########
@@ -825,7 +825,7 @@ http://commons.apache.org/validator/dependencies.html
     <action dev="niallp" type="fix" issue="VALIDATOR-60" due-to="Yugandhar">
      Change JavaScript validators to cater for disabled being undefined (an issue in Netscape 4.7).
     </action>
-    <action dev="niallp" type="add">
+    <action dev="niallp" type="add"><![CDATA[

Review Comment:
   action body can not contains more tags ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #298:
URL: https://github.com/apache/commons-validator/pull/298#issuecomment-2564535767

   Please use separate PRs for each independent change so they can be separately evaluated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF closed pull request #298: Test parent 79
URL: https://github.com/apache/commons-validator/pull/298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Test parent 79 [commons-validator]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #298:
URL: https://github.com/apache/commons-validator/pull/298#issuecomment-2564564265

   It would help if the title and description bore some relation to the purpose of the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Bump org.apache.commons:commons-parent from 78 to 79, fix changes.xml format for new plugin version [commons-validator]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF merged PR #298:
URL: https://github.com/apache/commons-validator/pull/298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org