You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by rs...@apache.org on 2021/10/13 09:56:55 UTC
[avro] branch master updated: AVRO-3171: JS: fix test failures on
Node.js 16 (#1354)
This is an automated email from the ASF dual-hosted git repository.
rskraba pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git
The following commit(s) were added to refs/heads/master by this push:
new fb398e0 AVRO-3171: JS: fix test failures on Node.js 16 (#1354)
fb398e0 is described below
commit fb398e0ddbdd67ae50909533f55defe52488e5da
Author: Martin Grigorov <ma...@users.noreply.github.com>
AuthorDate: Wed Oct 13 12:55:02 2021 +0300
AVRO-3171: JS: fix test failures on Node.js 16 (#1354)
Add Node.js to the GitHub Actions workflow
---
.github/workflows/test-lang-js.yml | 2 ++
lang/js/lib/protocols.js | 2 ++
2 files changed, 4 insertions(+)
diff --git a/.github/workflows/test-lang-js.yml b/.github/workflows/test-lang-js.yml
index 1f5bebc..3b28dd7 100644
--- a/.github/workflows/test-lang-js.yml
+++ b/.github/workflows/test-lang-js.yml
@@ -37,6 +37,7 @@ jobs:
node:
- 12
- 14
+ - 16
steps:
- uses: actions/checkout@v2
- name: Setup Node
@@ -65,6 +66,7 @@ jobs:
node:
- 12
- 14
+ - 16
steps:
- uses: actions/checkout@v2
- name: Setup Node
diff --git a/lang/js/lib/protocols.js b/lang/js/lib/protocols.js
index 7a5b9de..f347362 100644
--- a/lang/js/lib/protocols.js
+++ b/lang/js/lib/protocols.js
@@ -1099,6 +1099,8 @@ MessageDecoder.prototype._flush = function () {
this.emit('error', new Error('trailing data'));
} else if (this._empty) {
this.emit('error', new Error('no message decoded'));
+ } else {
+ this.emit('finish');
}
};