You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Peter Vary <pv...@cloudera.com> on 2016/10/10 13:53:29 UTC
Re: Review Request 49882: HIVE-14146: Column comments with "\n"
character "corrupts" table metadata
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49882/
-----------------------------------------------------------
(Updated Oct. 10, 2016, 1:53 p.m.)
Review request for hive, Aihua Xu, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.
Bugs: HIVE-14146
https://issues.apache.org/jira/browse/HIVE-14146
Repository: hive-git
Description
-------
The patch contains:
- MetaDataFormatUtils changes - to escape the \n in index, and column comments (table comments are already handled)
- TextMetaDataFormatter changes - to escape the \n in database comments
- DDLTask chages - to escape \n in show create table result
- New query test, to test the escaping
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/HiveStringUtils.java 72c3fa9
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java ec31cf4
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java ba4f6a7
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 47d67b1
ql/src/test/queries/clientpositive/escape_comments.q PRE-CREATION
ql/src/test/results/clientnegative/alter_view_as_select_with_partition.q.out 9b84227
ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out f3c10ee
ql/src/test/results/clientpositive/alter_view_as_select.q.out 2d82395
ql/src/test/results/clientpositive/columnstats_part_coltype.q.out 84232b6
ql/src/test/results/clientpositive/create_like.q.out 0111c94
ql/src/test/results/clientpositive/create_view.q.out 7281185
ql/src/test/results/clientpositive/create_view_partitioned.q.out 15d777a
ql/src/test/results/clientpositive/create_view_translate.q.out 2789f8f
ql/src/test/results/clientpositive/create_with_constraints.q.out b040e43
ql/src/test/results/clientpositive/describe_comment_indent.q.out 5a01de1
ql/src/test/results/clientpositive/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/49882/diff/
Testing
-------
New unit test and manually
Thanks,
Peter Vary
Re: Review Request 49882: HIVE-14146: Column comments with "\n"
character "corrupts" table metadata
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49882/
-----------------------------------------------------------
(Updated Oct. 10, 2016, 2:07 p.m.)
Review request for hive, Aihua Xu, Sergio Pena, Szehon Ho, and Vihang Karajgaonkar.
Changes
-------
Published the wrong diff before
Bugs: HIVE-14146
https://issues.apache.org/jira/browse/HIVE-14146
Repository: hive-git
Description
-------
The patch contains:
- MetaDataFormatUtils changes - to escape the \n in index, and column comments (table comments are already handled)
- TextMetaDataFormatter changes - to escape the \n in database comments
- DDLTask chages - to escape \n in show create table result
- New query test, to test the escaping
Diffs (updated)
-----
common/src/java/org/apache/hive/common/util/HiveStringUtils.java 72c3fa9
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a59b781
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java 03803bb
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java 47d67b1
ql/src/test/queries/clientpositive/escape_comments.q PRE-CREATION
ql/src/test/results/clientnegative/alter_view_as_select_with_partition.q.out 9b84227
ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out f3c10ee
ql/src/test/results/clientpositive/alter_view_as_select.q.out 2d82395
ql/src/test/results/clientpositive/columnstats_part_coltype.q.out 84232b6
ql/src/test/results/clientpositive/create_like.q.out 0111c94
ql/src/test/results/clientpositive/create_view.q.out d9c1e11
ql/src/test/results/clientpositive/create_view_partitioned.q.out 15d777a
ql/src/test/results/clientpositive/create_view_translate.q.out 2789f8f
ql/src/test/results/clientpositive/create_with_constraints.q.out b040e43
ql/src/test/results/clientpositive/describe_comment_indent.q.out 5a01de1
ql/src/test/results/clientpositive/escape_comments.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/49882/diff/
Testing
-------
New unit test and manually
Thanks,
Peter Vary