You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "windro-xdd (via GitHub)" <gi...@apache.org> on 2026/04/17 20:07:48 UTC
[PR] SFTP: remove deprecated timezone imports in sensor/trigger [airflow]
windro-xdd opened a new pull request, #65442:
URL: https://github.com/apache/airflow/pull/65442
This updates the SFTP sensor and trigger to use from instead of importing from .
It keeps the same comparison/UTC conversion behavior and adds regression tests to ensure importing these modules does not emit for .
related: #65419
##### What I tested
- [94mRunning command in Breeze: pytest [0m
[94mproviders/sftp/tests/unit/sftp/sensors/test_sftp.py [0m
[94mproviders/sftp/tests/unit/sftp/triggers/test_sftp.py -xs[0m
[94mUsing project name: breeze-run-f036ffcb[0m
[94mCI image already built locally.[0m
[94mRunning command: [0m[1;94m<[0m[1;94mdocker[0m[94m inspect ghcr.io/apache/airflow/main/ci/python3.[0m[1;94m10[0m[1;94m>[0m
[94mWorking directory [0m[94m/home/wnxd/[0m[94mairflow-repo[0m
[94mdocker inspect ghcr.io/apache/airflow/main/ci/python3.[0m[1;94m10[0m
[93mThe following important files are modified in [0m[93m/home/wnxd/[0m[93mairflow-repo[0m[93m since last[0m
[93mtime image was built: [0m
* [94mDockerfile.ci[0m
[93mLikely CI image needs rebuild[0m
Do you want to build the image [1m([0mthis works best when you have good connection
and can take usually from [1;36m20[0m seconds to few minutes depending how old your image
is[1m)[0m?
Press y/N/q:
Terminating the process on [1m[[0mErrno [1;36m1[0m[1m][0m Operation not permitted
- [94mRunning command in Breeze: pytest [0m
[94mproviders/sftp/tests/unit/sftp/decorators/sensors/test_sftp.py -xs[0m
[94mUsing project name: breeze-run-438c6158[0m
[94mCI image already built locally.[0m
[94mRunning command: [0m[1;94m<[0m[1;94mdocker[0m[94m inspect ghcr.io/apache/airflow/main/ci/python3.[0m[1;94m10[0m[1;94m>[0m
[94mWorking directory [0m[94m/home/wnxd/[0m[94mairflow-repo[0m
[94mdocker inspect ghcr.io/apache/airflow/main/ci/python3.[0m[1;94m10[0m
[93mThe following important files are modified in [0m[93m/home/wnxd/[0m[93mairflow-repo[0m[93m since last[0m
[93mtime image was built: [0m
* [94mDockerfile.ci[0m
[93mLikely CI image needs rebuild[0m
Do you want to build the image [1m([0mthis works best when you have good connection
and can take usually from [1;36m20[0m seconds to few minutes depending how old your image
is[1m)[0m?
Press y/N/q:
Terminating the process on [1m[[0mErrno [1;36m1[0m[1m][0m Operation not permitted
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (OpenCode gpt-5.3-codex)
Generated-by: OpenCode gpt-5.3-codex following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SFTP: use compat timezone helpers in sensor and trigger [airflow]
Posted by "windro-xdd (via GitHub)" <gi...@apache.org>.
windro-xdd commented on PR #65442:
URL: https://github.com/apache/airflow/pull/65442#issuecomment-4273285781
Thanks for the review — updated now.\n\n- Adjusted the PR title to avoid implying a breaking change\n- Reworded the commit messages accordingly\n\nPlease take another look when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use compat timezone helpers in sensor and trigger of SFTP provider [airflow]
Posted by "dabla (via GitHub)" <gi...@apache.org>.
dabla merged PR #65442:
URL: https://github.com/apache/airflow/pull/65442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SFTP: remove deprecated timezone imports in sensor/trigger [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #65442:
URL: https://github.com/apache/airflow/pull/65442#issuecomment-4273274284
Please ammend commit message and PR title. It sounds like you are suggesting a breaking change which is not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org