You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2017/10/20 02:01:00 UTC

[jira] [Resolved] (JCRVLT-209) Always write to the filter.xml inside the vaultDir but never to filter-plugin-generated.xml

     [ https://issues.apache.org/jira/browse/JCRVLT-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tobias Bocanegra resolved JCRVLT-209.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: package-maven-plugin-1.0.0

fixed in r1812696

> Always write to the filter.xml inside the vaultDir but never to filter-plugin-generated.xml
> -------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-209
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-209
>             Project: Jackrabbit FileVault
>          Issue Type: Improvement
>          Components: package maven plugin
>            Reporter: Konrad Windszus
>            Assignee: Tobias Bocanegra
>             Fix For: package-maven-plugin-1.0.0
>
>
> Currently in case the filter configuration of the plugin has been changed and there is already a {{filter.xml}} in the {{vaultDir}} this is not being overwritten. Instead a new file named {{filter-plugin-generated.xml}} is being generated which is irrelevant for the package (https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/15baff9be241a851d4ad36e53336cec1d5613c9d/plugin/src/main/java/org/apache/jackrabbit/filevault/maven/packaging/VaultMojo.java#L372). IMHO this is not a clever default behaviour because it forces to always use {{mvn clean}} in case of filter definition changes.
> In case someone want's to really manually modify the filter.xml the parameter {{filterSource}} should be used instead, but in any case the generated {{filter.xml}} inside the {{vaultDir}} should contain the latest generated filter file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)