You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Lai <ja...@jasonlai.net> on 2018/06/18 21:49:00 UTC
Re: Review Request 66875: Added an hourly timer for docker store pull
latency.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review204958
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Lai
On May 21, 2018, 5:16 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> -----------------------------------------------------------
>
> (Updated May 21, 2018, 5:16 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 8b3f07f5027cb90d4b4ed401960494709d3eda5f
>
>
> Diff: https://reviews.apache.org/r/66875/diff/2/
>
>
> Testing
> -------
>
> Ran agent in command line and trigger several launches through `mesos-execute`, observed following metrics from agent endpoint:
>
> ```
> "containerizer/mesos/docker_store/pull_ms": 4084.254208,
> "containerizer/mesos/docker_store/pull_ms/count": 2,
> "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
> "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
> "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
> "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
> "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
> "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
> "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
> "containerizer/mesos/docker_store/pull_ms/p9999": 4084.1982870528,
> ```
>
>
> Thanks,
>
> Zhitao Li
>
>