You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/05/31 19:24:42 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #207: Improve focus handling in spec-editor directive
algairim opened a new pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207
Signed-off-by: Mykola Mandra <my...@cloudsoftcorp.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853683006
<img width="846" alt="Screenshot 2021-06-03 at 09 16 29" src="https://user-images.githubusercontent.com/81319331/120612371-088e4700-c44d-11eb-81b1-fc7bc8805167.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 15" src="https://user-images.githubusercontent.com/81319331/120612376-09bf7400-c44d-11eb-91af-1e67815d9fd2.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 41" src="https://user-images.githubusercontent.com/81319331/120612378-0a580a80-c44d-11eb-8669-9cb21a9aa06e.png">
<img width="1126" alt="Screenshot 2021-06-03 at 09 19 05" src="https://user-images.githubusercontent.com/81319331/120612379-0af0a100-c44d-11eb-8084-ce50180c2515.png">
<img width="548" alt="Screenshot 2021-06-03 at 09 19 18" src="https://user-images.githubusercontent.com/81319331/120612381-0b893780-c44d-11eb-808b-4f765078f40b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#discussion_r644563386
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -106,7 +110,7 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
function controller($scope, $element) {
(composerOverrides.configureSpecEditorController || function () {
- })(this, $scope, $element);
+ })(this, $scope, $element, blueprintService);
Review comment:
Blueprint service is required for branding configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853968429
nice cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim removed a comment on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim removed a comment on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853683006
<img width="846" alt="Screenshot 2021-06-03 at 09 16 29" src="https://user-images.githubusercontent.com/81319331/120612371-088e4700-c44d-11eb-81b1-fc7bc8805167.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 15" src="https://user-images.githubusercontent.com/81319331/120612376-09bf7400-c44d-11eb-91af-1e67815d9fd2.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 41" src="https://user-images.githubusercontent.com/81319331/120612378-0a580a80-c44d-11eb-8669-9cb21a9aa06e.png">
<img width="1126" alt="Screenshot 2021-06-03 at 09 19 05" src="https://user-images.githubusercontent.com/81319331/120612379-0af0a100-c44d-11eb-8084-ce50180c2515.png">
<img width="548" alt="Screenshot 2021-06-03 at 09 19 18" src="https://user-images.githubusercontent.com/81319331/120612381-0b893780-c44d-11eb-808b-4f765078f40b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] duncangrant merged pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#discussion_r642869699
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -406,11 +414,18 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
}
return $filter('specEditorConfig')(allConfig, scope.state.config.filter.values).indexOf(config) === -1;
};
+ specEditor.recordFocus = (subsection, name) => {
+ scope.state.focus.subsection = subsection;
+ scope.state.focus.name = name;
+ };
Review comment:
A single subsection must be in focus only. Previously, only the last subsection was focused on refresh (when DSL menu closes) if multiple expected to be in focus, like property or configuration at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] duncangrant merged pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
duncangrant merged pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#discussion_r642867174
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -181,6 +187,10 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
}
};
+ scope.state = sessionStorage && sessionStorage.getItem(scope.model._id)
+ ? JSON.parse(sessionStorage.getItem(scope.model._id))
+ : defaultState;
Review comment:
Moved up to enable external configuration, e.g. branding.
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -181,6 +187,10 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
}
};
+ scope.state = sessionStorage && sessionStorage.getItem(scope.model._id)
+ ? JSON.parse(sessionStorage.getItem(scope.model._id))
+ : defaultState;
Review comment:
Moved up to enable external configuration of the state, e.g. branding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#discussion_r644563386
##########
File path: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.directive.js
##########
@@ -106,7 +110,7 @@ export function specEditorDirective($rootScope, $templateCache, $injector, $sani
function controller($scope, $element) {
(composerOverrides.configureSpecEditorController || function () {
- })(this, $scope, $element);
+ })(this, $scope, $element, blueprintService);
Review comment:
Blueprint service is required for branding configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853968429
nice cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim removed a comment on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim removed a comment on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853683006
<img width="846" alt="Screenshot 2021-06-03 at 09 16 29" src="https://user-images.githubusercontent.com/81319331/120612371-088e4700-c44d-11eb-81b1-fc7bc8805167.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 15" src="https://user-images.githubusercontent.com/81319331/120612376-09bf7400-c44d-11eb-91af-1e67815d9fd2.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 41" src="https://user-images.githubusercontent.com/81319331/120612378-0a580a80-c44d-11eb-8669-9cb21a9aa06e.png">
<img width="1126" alt="Screenshot 2021-06-03 at 09 19 05" src="https://user-images.githubusercontent.com/81319331/120612379-0af0a100-c44d-11eb-8084-ce50180c2515.png">
<img width="548" alt="Screenshot 2021-06-03 at 09 19 18" src="https://user-images.githubusercontent.com/81319331/120612381-0b893780-c44d-11eb-808b-4f765078f40b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on pull request #207: Improve focus handling in spec-editor directive
Posted by GitBox <gi...@apache.org>.
algairim commented on pull request #207:
URL: https://github.com/apache/brooklyn-ui/pull/207#issuecomment-853683006
<img width="846" alt="Screenshot 2021-06-03 at 09 16 29" src="https://user-images.githubusercontent.com/81319331/120612371-088e4700-c44d-11eb-81b1-fc7bc8805167.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 15" src="https://user-images.githubusercontent.com/81319331/120612376-09bf7400-c44d-11eb-91af-1e67815d9fd2.png">
<img width="1106" alt="Screenshot 2021-06-03 at 09 18 41" src="https://user-images.githubusercontent.com/81319331/120612378-0a580a80-c44d-11eb-8669-9cb21a9aa06e.png">
<img width="1126" alt="Screenshot 2021-06-03 at 09 19 05" src="https://user-images.githubusercontent.com/81319331/120612379-0af0a100-c44d-11eb-8084-ce50180c2515.png">
<img width="548" alt="Screenshot 2021-06-03 at 09 19 18" src="https://user-images.githubusercontent.com/81319331/120612381-0b893780-c44d-11eb-808b-4f765078f40b.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org